From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753007AbaE0SOS (ORCPT ); Tue, 27 May 2014 14:14:18 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:53766 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751946AbaE0SOR (ORCPT ); Tue, 27 May 2014 14:14:17 -0400 Date: Tue, 27 May 2014 11:14:15 -0700 From: Christoph Hellwig To: Jens Axboe Cc: Mikulas Patocka , Mike Snitzer , Kent Overstreet , "Alasdair G. Kergon" , linux-kernel@vger.kernel.org, dm-devel@redhat.com Subject: Re: [dm-devel] [PATCH] block: flush queued bios when the process blocks Message-ID: <20140527181415.GA8739@infradead.org> References: <5384AA79.4010206@kernel.dk> <5384B26D.1000703@kernel.dk> <5384CE82.90601@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5384CE82.90601@kernel.dk> User-Agent: Mutt/1.5.21 (2010-09-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 27, 2014 at 11:42:26AM -0600, Jens Axboe wrote: > Except such a thing already exists, there are unplug callback > chains. All I'm asking is that you look into how feasible it would > be to use something like that, instead of reinventing the wheel. I suspect the code from MD could be lifted quite easily. It would be nicer to move it up to the block layer entirely, but when I tried that a while ago I ran into issues that I unfortunately don't remember.