From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753182AbaE0Wy2 (ORCPT ); Tue, 27 May 2014 18:54:28 -0400 Received: from mail-ie0-f173.google.com ([209.85.223.173]:40708 "EHLO mail-ie0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752541AbaE0Wy0 (ORCPT ); Tue, 27 May 2014 18:54:26 -0400 Date: Tue, 27 May 2014 16:54:22 -0600 From: Bjorn Helgaas To: Arnd Bergmann Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Magnus Damm , linux-pci@vger.kernel.org, linux-sh@vger.kernel.org Subject: Re: [PATCH] pci: rcar host needs OF Message-ID: <20140527225422.GE11907@google.com> References: <1399560433-1402630-1-git-send-email-arnd@arndb.de> <1399560990-1402858-1-git-send-email-arnd@arndb.de> <1399560990-1402858-14-git-send-email-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1399560990-1402858-14-git-send-email-arnd@arndb.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 08, 2014 at 04:56:25PM +0200, Arnd Bergmann wrote: > The pci-rcar driver is enabled for compile tests, and this has > now shown that the driver cannot build without CONFIG_OF, > following the inclusion of f8f2fe7355fb "PCI: rcar: Use new OF > interrupt mapping when possible": > > drivers/built-in.o: In function `rcar_pci_map_irq': > :(.text+0x1cc7c): undefined reference to `of_irq_parse_and_map_pci' > > Signed-off-by: Arnd Bergmann > Cc: Bjorn Helgaas > Cc: Magnus Damm > Cc: linux-pci@vger.kernel.org > Cc: linux-sh@vger.kernel.org If I understand correctly, this patch was superceded by this one: "[PATCH] of/irq: provide int of_irq_parse_and_map_pci wrapper" and you aren't expecting me to do anything. Let me know if otherwise. > --- > drivers/pci/host/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig > index fbbef0b..4675f47 100644 > --- a/drivers/pci/host/Kconfig > +++ b/drivers/pci/host/Kconfig > @@ -27,7 +27,7 @@ config PCI_TEGRA > > config PCI_RCAR_GEN2 > bool "Renesas R-Car Gen2 Internal PCI controller" > - depends on ARCH_SHMOBILE || (ARM && COMPILE_TEST) > + depends on ARCH_SHMOBILE || (ARM && OF && COMPILE_TEST) > help > Say Y here if you want internal PCI support on R-Car Gen2 SoC. > There are 3 internal PCI controllers available with a single > -- > 1.8.3.2 >