From: Steven Rostedt <rostedt@goodmis.org>
To: Petr Mladek <pmladek@suse.cz>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
Jiri Kosina <jkosina@suse.cz>,
linux-kernel@vger.kernel.org, x86@kernel.org
Subject: Re: [PATCH] ftrace/x86: Call text_ip_addr() instead of the duplicated code
Date: Tue, 3 Jun 2014 19:01:51 -0400 [thread overview]
Message-ID: <20140603190151.0f8e2087@gandalf.local.home> (raw)
In-Reply-To: <1401812601-2359-1-git-send-email-pmladek@suse.cz>
On Tue, 3 Jun 2014 18:23:21 +0200
Petr Mladek <pmladek@suse.cz> wrote:
> I just went over this when looking at some Xen-related ftrace initialization
> problems. They were related to Xen code that is not upstream but this clean up
> would make sense here.
>
> I think that this was already the intention when text_ip_addr() was introduced
> in the commit 87fbb2ac6073a703930 (ftrace/x86: Use breakpoints for converting
> function graph caller). Anyway, better do it now before it shots people into
> their leg ;-)
You know, I made this change. It somehow got lost :-/
I better analyze this a bit to make sure it was just lost and I didn't
find some odd ball reason not to apply it. But I doubt I'll find
anything. If not, I'll get it enqueued for 3.16.
Thanks!
-- Steve
>
> Signed-off-by: Petr Mladek <pmladek@suse.cz>
> ---
> arch/x86/kernel/ftrace.c | 11 +----------
> 1 file changed, 1 insertion(+), 10 deletions(-)
>
> diff --git a/arch/x86/kernel/ftrace.c b/arch/x86/kernel/ftrace.c
> index 89de3eaf8772..cbc4a91b131e 100644
> --- a/arch/x86/kernel/ftrace.c
> +++ b/arch/x86/kernel/ftrace.c
> @@ -297,16 +297,7 @@ int ftrace_int3_handler(struct pt_regs *regs)
>
> static int ftrace_write(unsigned long ip, const char *val, int size)
> {
> - /*
> - * On x86_64, kernel text mappings are mapped read-only with
> - * CONFIG_DEBUG_RODATA. So we use the kernel identity mapping instead
> - * of the kernel text mapping to modify the kernel text.
> - *
> - * For 32bit kernels, these mappings are same and we can use
> - * kernel identity mapping to modify code.
> - */
> - if (within(ip, (unsigned long)_text, (unsigned long)_etext))
> - ip = (unsigned long)__va(__pa_symbol(ip));
> + ip = text_ip_addr(ip);
>
> if (probe_kernel_write((void *)ip, val, size))
> return -EPERM;
prev parent reply other threads:[~2014-06-03 23:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-03 16:23 [PATCH] ftrace/x86: Call text_ip_addr() instead of the duplicated code Petr Mladek
2014-06-03 23:01 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140603190151.0f8e2087@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=fweisbec@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=pmladek@suse.cz \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).