From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752081AbaFDJdX (ORCPT ); Wed, 4 Jun 2014 05:33:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:62525 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751729AbaFDJdV (ORCPT ); Wed, 4 Jun 2014 05:33:21 -0400 Date: Wed, 4 Jun 2014 11:33:14 +0200 From: Jiri Olsa To: Steven Rostedt Cc: Namhyung Kim , linux-kernel@vger.kernel.org, Ingo Molnar , Andrew Morton Subject: Re: [PATCH v3 2/4] tools lib traceevent: Add options to plugins Message-ID: <20140604093314.GA1348@krava.brq.redhat.com> References: <20140603032012.088137043@goodmis.org> <20140603032223.896255043@goodmis.org> <87lhtecwph.fsf@sejong.aot.lge.com> <20140603184154.0a4c031c@gandalf.local.home> <20140603184310.4be2d339@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140603184310.4be2d339@gandalf.local.home> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 03, 2014 at 06:43:10PM -0400, Steven Rostedt wrote: > On Tue, 3 Jun 2014 18:41:54 -0400 > Steven Rostedt wrote: > > > > > The traceevent plugins allows developers to have their events print out > > information that is more advanced than what can be achieved by the > > trace event format files. > > > > As these plugins are used on the userspace side of the tracing tools, it > > is only logical that the tools should be able to produce different types > > of output for the events. The types of events still need to be defined by > > the plugins thus we need a way to pass information from the tool to the > > plugin to specify what type of information to be shown. > > > > Not only does the information need to be passed by the tool to plugin, but > > the plugin also requires a way to notify the tool of what options it can > > provide. > > > > This builds the plugin option infrastructure that is taken from trace-cmd > > that is used to allow plugins to produce different output based on the > > options specified by the tool. > > > > Signed-off-by: Steven Rostedt > > Jiri, > > I only sent this patch for v3, as the 1,3,4 are fine. Do you want me to > send a full series? Or can you just pull in v2 of patches 1,3 and 4 and > then v3 of this one? no need to resend, I'll take it from here jirka