From: Stephen Rothwell <sfr@canb.auug.org.au>
To: "Michael S. Tsirkin" <mst@redhat.com>,
Nicholas Bellinger <nab@linux-iscsi.org>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: linux-next: build failure after merge of the vhost tree
Date: Tue, 10 Jun 2014 14:12:17 +1000 [thread overview]
Message-ID: <20140610141217.50d98cd6@canb.auug.org.au> (raw)
[-- Attachment #1: Type: text/plain, Size: 1459 bytes --]
Hi Michael,
After merging the vhost tree, today's linux-next build (x86_64
allmodconfig) failed like this:
drivers/vhost/scsi.c: In function 'vhost_scsi_handle_vq':
drivers/vhost/scsi.c:1043:14: error: 'struct vhost_dev' has no member named 'acked_features'
if (vs->dev.acked_features & VIRTIO_SCSI_F_T10_PI) {
^
Commit 95e7c4341b8e ("vhost/scsi: Enable T10 PI IOV -> SGL memory
mapping") from the target-updates tree interacting with commit
10350a292160 ("vhost: move acked_features to VQs") from the vhost tree.
I applied the following patch which seems right, but may not be.
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 10 Jun 2014 14:08:21 +1000
Subject: [PATCH] vhost/scsi: fixup for acked_features move
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
drivers/vhost/scsi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c
index 78ff1f64d759..6d7dd85365fe 100644
--- a/drivers/vhost/scsi.c
+++ b/drivers/vhost/scsi.c
@@ -1040,7 +1040,7 @@ vhost_scsi_handle_vq(struct vhost_scsi *vs, struct vhost_virtqueue *vq)
break;
}
- if (vs->dev.acked_features & VIRTIO_SCSI_F_T10_PI) {
+ if (vhost_has_feature(vq, VIRTIO_SCSI_F_T10_PI)) {
req = &v_req_pi;
lunp = &v_req_pi.lun[0];
target = &v_req_pi.lun[1];
--
2.0.0
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next reply other threads:[~2014-06-10 4:12 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-10 4:12 Stephen Rothwell [this message]
2014-06-10 9:38 ` linux-next: build failure after merge of the vhost tree Michael S. Tsirkin
-- strict thread matches above, loose matches on Subject: below --
2024-02-29 3:55 Stephen Rothwell
2024-02-29 4:01 ` Xuan Zhuo
2024-02-29 7:21 ` Xuan Zhuo
2022-08-16 1:13 Stephen Rothwell
2022-06-01 1:42 Stephen Rothwell
2022-06-01 21:57 ` Michael S. Tsirkin
2022-06-02 3:19 ` Stephen Rothwell
2021-11-25 1:23 Stephen Rothwell
2021-09-06 2:49 Stephen Rothwell
2021-09-06 2:57 ` Yongji Xie
2021-07-08 1:08 Stephen Rothwell
2021-07-08 5:37 ` Michael S. Tsirkin
2020-08-04 5:11 Stephen Rothwell
2020-08-04 5:47 ` Guennadi Liakhovetski
2020-08-04 7:04 ` Guennadi Liakhovetski
2020-08-04 9:15 ` Michael S. Tsirkin
2020-07-30 7:52 Stephen Rothwell
2020-07-28 8:11 Stephen Rothwell
2020-07-29 14:08 ` Michael S. Tsirkin
2020-05-07 5:36 Stephen Rothwell
2020-04-07 3:05 Stephen Rothwell
2020-04-07 10:01 ` Michael S. Tsirkin
2020-04-07 18:58 ` Nathan Chancellor
2020-04-09 21:15 ` Michael S. Tsirkin
2019-12-04 3:24 Stephen Rothwell
2019-12-07 23:45 ` Stephen Rothwell
2019-12-09 15:24 ` Michael S. Tsirkin
2018-02-07 2:04 Stephen Rothwell
2018-02-07 2:52 ` Michael S. Tsirkin
2018-02-07 2:54 ` Stephen Rothwell
2018-02-07 2:57 ` Michael S. Tsirkin
2018-02-07 4:30 ` Stephen Rothwell
2017-03-30 4:25 Stephen Rothwell
2017-04-03 6:21 ` Stephen Rothwell
2014-06-03 8:38 Stephen Rothwell
2014-06-09 13:19 ` Michael S. Tsirkin
2013-05-22 4:37 Stephen Rothwell
2013-05-22 5:07 ` Michael S. Tsirkin
2013-05-22 9:03 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140610141217.50d98cd6@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mst@redhat.com \
--cc=nab@linux-iscsi.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).