From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>,
linux-kernel@vger.kernel.org,
Corey Ashford <cjashfor@linux.vnet.ibm.com>,
David Ahern <dsahern@gmail.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@kernel.org>, Paul Mackerras <paulus@samba.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH 5/5] perf tools: Add report.show-headers config file option
Date: Thu, 19 Jun 2014 12:28:43 -0300 [thread overview]
Message-ID: <20140619152843.GB20252@kernel.org> (raw)
In-Reply-To: <1403182604.1670.26.camel@leonhard>
Em Thu, Jun 19, 2014 at 09:56:44PM +0900, Namhyung Kim escreveu:
> 2014-06-19 (목), 13:41 +0200, Jiri Olsa:
> > Adding report.show-headers config file option to setup
> > the appearance of the columns headers.
> >
> > Currently columns headers are displayed by default, following
> > lines in ~/.perfconfig file will disable that:
> >
> > [report]
> > show-headers = true
>
> This also applies to perf top, right? And it's TUI-specific. So how
> about calling it something like "tui.show-headers"?
Why should it be TUI specific? You either show the headers or you don't,
in all UIs.
And also in all tools, I think, so I suggest putting it in some global,
for all tools, section in the config file, i.e. something like
all.show-headers.
- Arnaldo
next prev parent reply other threads:[~2014-06-19 15:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-19 11:41 [PATCHv2 0/5] perf tools tui: Display columns headers Jiri Olsa
2014-06-19 11:41 ` [PATCH 1/5] perf tools: Factor ui_browser ops out of ui_browser struct Jiri Olsa
2014-06-19 15:38 ` Arnaldo Carvalho de Melo
2014-06-19 16:49 ` Jiri Olsa
2014-06-19 23:33 ` Namhyung Kim
2014-06-19 11:41 ` [PATCH 2/5] perf tools: Remove ev_name argument from perf_evsel__hists_browse Jiri Olsa
2014-06-19 15:41 ` Arnaldo Carvalho de Melo
2014-06-25 5:51 ` [tip:perf/core] perf hists browser: " tip-bot for Jiri Olsa
2014-06-19 11:41 ` [PATCH 3/5] perf tools: Fix scrollbar refresh row index Jiri Olsa
2014-06-25 5:51 ` [tip:perf/core] perf ui browser: " tip-bot for Jiri Olsa
2014-06-19 11:41 ` [PATCH 4/5] perf tools tui: Display columns header text on 'H' press Jiri Olsa
2014-06-19 11:41 ` [PATCH 5/5] perf tools: Add report.show-headers config file option Jiri Olsa
2014-06-19 12:56 ` Namhyung Kim
2014-06-19 13:02 ` Jiri Olsa
2014-06-19 13:09 ` Namhyung Kim
2014-06-19 16:51 ` Jiri Olsa
2014-06-19 23:37 ` Namhyung Kim
2014-06-19 15:28 ` Arnaldo Carvalho de Melo [this message]
2014-06-19 16:58 ` Jiri Olsa
2014-06-19 23:46 ` Namhyung Kim
2014-06-20 8:03 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140619152843.GB20252@kernel.org \
--to=acme@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=cjashfor@linux.vnet.ibm.com \
--cc=dsahern@gmail.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).