From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756723AbaFWTlO (ORCPT ); Mon, 23 Jun 2014 15:41:14 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:41158 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756707AbaFWTlL (ORCPT ); Mon, 23 Jun 2014 15:41:11 -0400 X-Sasl-enc: W+LWXFmJmSOi/uJ1k/hfaC4PIuqpMKciY1Z2mRQFakFG 1403552470 Date: Mon, 23 Jun 2014 15:40:59 -0400 From: Greg KH To: Johan Hovold Cc: Janne Kanniainen , jkosina@suse.cz, cooloney@gmail.com, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, linux-usb@vger.kernel.org, linux-input@vger.kernel.org Subject: Re: [PATCH v10] leds: USB: HID: Add support for MSI GT683R led panels Message-ID: <20140623194059.GA19615@kroah.com> References: <20140623161723.GA20421@kroah.com> <1403543808-8228-1-git-send-email-janne.kanniainen@gmail.com> <20140623182324.GA30831@kroah.com> <20140623182432.GB30831@kroah.com> <20140623193134.GA15945@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140623193134.GA15945@localhost> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 23, 2014 at 09:31:34PM +0200, Johan Hovold wrote: > On Mon, Jun 23, 2014 at 02:24:32PM -0400, Greg KH wrote: > > On Mon, Jun 23, 2014 at 02:23:24PM -0400, Greg KH wrote: > > > On Mon, Jun 23, 2014 at 08:16:48PM +0300, Janne Kanniainen wrote: > > > > + ret = sysfs_create_group(&led->hdev->dev.kobj, >683r_attribute_group); > > > > + if (ret) { > > > > + hid_err(hdev, "failed to create sysfs attributes\n"); > > > > + goto fail; > > > > + } > > > > > > No, you need to set the attribute group _before_ you call > > > led_classdev_register, as that is where the device will be created in > > > sysfs. Surely the other led drivers already do this? I'm almost afraid > > > to go look... > > > > Yes, they do it already, set .dev_attr_group and you should be fine. > > But this isn't an attribute of the LEDs but rather of the parent HID > device that is being probed (the led_mode is common to all three LEDs > and thus belongs in the parent device, right?). Then that's even worse :( The sysfs attribute should be on the class device here for the LED, you should not put an attribute on a device you are not the driver for. greg k-h