From: Peter Zijlstra <peterz@infradead.org>
To: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org, Robert Richter <rric@kernel.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Mike Galbraith <efault@gmx.de>, Paul Mackerras <paulus@samba.org>,
Stephane Eranian <eranian@google.com>,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [RFC v2 2/7] perf: add AUX area to ring buffer for raw data streams
Date: Tue, 24 Jun 2014 19:19:43 +0200 [thread overview]
Message-ID: <20140624171943.GR3213@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1402501310-31940-3-git-send-email-alexander.shishkin@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 525 bytes --]
On Wed, Jun 11, 2014 at 06:41:45PM +0300, Alexander Shishkin wrote:
> + /*
> + * Set up pmu-private data structures for an AUX area
> + */
> + void *(*setup_aux) (int cpu, void **pages,
> + int nr_pages, bool overwrite);
> + /* optional */
> +
> + /*
> + * Free pmu-private AUX data structures
> + */
> + void (*free_aux) (void *aux); /* optional */
I was hoping you could replace those with a PERF_CAP_AUX or something
and then have one generic allocation routine like you provide in the
subsequent patches.
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-06-24 17:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-11 15:41 [RFC v2 0/7] perf: perf: add AUX space to ring_buffer Alexander Shishkin
2014-06-11 15:41 ` [RFC v2 1/7] perf: add data_{offset,size} to user_page Alexander Shishkin
2014-06-13 13:51 ` Robert Richter
2014-06-11 15:41 ` [RFC v2 2/7] perf: add AUX area to ring buffer for raw data streams Alexander Shishkin
2014-06-24 17:19 ` Peter Zijlstra [this message]
2014-06-25 11:09 ` Alexander Shishkin
2014-06-25 12:11 ` Peter Zijlstra
2014-06-11 15:41 ` [RFC v2 3/7] perf: support high-order allocations for AUX space Alexander Shishkin
2014-06-11 15:41 ` [RFC v2 4/7] perf: add a capability for AUX_NO_SG pmus to do software double buffering Alexander Shishkin
2014-06-11 15:41 ` [RFC v2 5/7] perf: add a pmu capability for "exclusive" events Alexander Shishkin
2014-06-24 17:18 ` Peter Zijlstra
2014-06-25 11:12 ` Alexander Shishkin
2014-06-11 15:41 ` [RFC v2 6/7] perf: add api for pmus to write to AUX space Alexander Shishkin
2014-06-24 17:27 ` Peter Zijlstra
2014-06-25 11:24 ` Alexander Shishkin
2014-06-25 12:12 ` Peter Zijlstra
2014-06-11 15:41 ` [RFC v2 7/7] perf: add AUX record Alexander Shishkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140624171943.GR3213@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=efault@gmx.de \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=rric@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).