From: Lee Jones <lee.jones@linaro.org>
To: Peter Griffin <peter.griffin@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, maxime.coquelin@st.com,
patrice.chotard@st.com, srinivas.kandagatla@gmail.com,
devicetree@vger.kernel.org, balbi@ti.com,
linux-usb@vger.kernel.org, linux-omap@vger.kernel.org,
peppe.cavallaro@st.com
Subject: Re: [PATCH v2 2/3] ARM: dts: sti: Add st-dwc3 devicetree bindings documentation
Date: Mon, 7 Jul 2014 12:00:55 +0100 [thread overview]
Message-ID: <20140707110055.GF6407@lee--X1> (raw)
In-Reply-To: <1404541530-27856-3-git-send-email-peter.griffin@linaro.org>
Subject is wrong, this has nothing to do with ARM. Should be USB.
On Sat, 05 Jul 2014, Peter Griffin wrote:
> This patch documents the device tree documentation required for
> the ST usb3 controller glue layer found in STiH407 devices.
>
> Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> ---
> Documentation/devicetree/bindings/usb/dwc3-st.txt | 58 +++++++++++++++++++++++
> 1 file changed, 58 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/usb/dwc3-st.txt
>
> diff --git a/Documentation/devicetree/bindings/usb/dwc3-st.txt b/Documentation/devicetree/bindings/usb/dwc3-st.txt
> new file mode 100644
> index 0000000..befd964
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/dwc3-st.txt
> @@ -0,0 +1,58 @@
> +ST DWC3 glue logic
> +
> +This file documents the parameters for the dwc3-st driver.
Does this line really add anything to do the document, considering the
name and location of the file and the title above?
> +This driver provides the glue logic to use the dwc3 on STiH407 based platforms.
s/This driver/The DWC2 driver/
> +Required properties:
> + - compatible : must be "st,stih407-dwc3"
> + - reg : glue logic base address and USB syscfg ctrl register offset
> + - reg-names : should be "reg-glue" and "syscfg-reg"
Any reason why you have reg-* and *-reg? If you have to put 'reg' in
the name, it's usually appended, rather than prefixed.
> + - st,syscon : should be phandle to system configuration node which
> + encompasses the glue registers
> + - resets : phandle pointing to the system powerdown controller
> +See: Documentation/devicetree/bindings/reset/st,sti-powerdown.txt
> +See: Documentation/devicetree/bindings/reset/reset.txt
> +
> + - #address-cells, #size-cells : should be '1' if the device has sub-nodes
> + with 'reg' property
> +
> + - pinctl-names : A pinctrl state named "default" must be defined
> +See: Documentation/devicetree/bindings/pinctrl/pinctrl-binding.txt
> +
> + - pinctrl-0 : Pin control group
> +See: Documentation/devicetree/bindings/pinctrl/pinctrl-binding.txt
> +
> + - ranges : allows valid 1:1 translation between child's address space and
> + parent's address space
> +
> +Optional properties:
> + - st,dwc3-drd-device: to program the HC as "device" (static setup)
This will require a DT Ack.
> +Sub-nodes:
> +The dwc3 core should be added as subnode to ST DWC3 glue as shown in the
> +example below. The DT binding details of dwc3 can be found in:
> +Documentation/devicetree/bindings/usb/dwc3.txt
> +
> +Example:
> +
> +st_dwc3: dwc3@8f94000 {
> + status = "disabled";
Probably not good to disable the node in the example.
> + compatible = "st,stih407-dwc3";
> + reg = <0x08f94000 0x1000>, <0x110 0x4>;
> + reg-names = "reg-glue", "syscfg-reg";
> + st,syscfg = <&syscfg_core>;
> + resets = <&powerdown STIH407_USB3_POWERDOWN>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_usb3>;
> + ranges;
> +
> + dwc3: dwc3@9900000 {
> + compatible = "synopsys,dwc3";
> + reg = <0x09900000 0x100000>;
> + interrupts = <GIC_SPI 155 IRQ_TYPE_NONE>;
> +
> + usb-phy = <&usb2_phy>, <&usb3_phy>;
> + };
> +};
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-07-07 11:01 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-05 6:25 [PATCH v2 0/3] Add ST dwc3 glue layer driver Peter Griffin
2014-07-05 6:25 ` [PATCH v2 1/3] usb: dwc3: add ST dwc3 glue layer to manage dwc3 HC Peter Griffin
2014-07-07 12:46 ` Lee Jones
2014-07-22 9:18 ` Peter Griffin
2014-07-22 10:15 ` Lee Jones
2014-07-22 14:57 ` Felipe Balbi
2014-07-22 15:45 ` Lee Jones
2014-07-22 15:51 ` Felipe Balbi
2014-07-22 15:56 ` Lee Jones
2014-07-23 14:33 ` Peter Griffin
2014-08-20 18:24 ` Felipe Balbi
2014-07-07 13:21 ` Jingoo Han
2014-07-22 9:38 ` Peter Griffin
2014-07-05 6:25 ` [PATCH v2 2/3] ARM: dts: sti: Add st-dwc3 devicetree bindings documentation Peter Griffin
2014-07-07 11:00 ` Lee Jones [this message]
2014-07-05 6:25 ` [PATCH v2 3/3] MAINTAINERS: Add dwc3-st.c file to ARCH/STI architecture Peter Griffin
2014-07-07 10:51 ` Lee Jones
2014-07-08 7:40 ` Maxime Coquelin
2014-07-08 7:53 ` Lee Jones
2014-07-08 9:01 ` Maxime Coquelin
2014-07-10 13:27 ` Felipe Balbi
2014-07-10 13:39 ` Lee Jones
2014-07-10 15:24 ` Peter Griffin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140707110055.GF6407@lee--X1 \
--to=lee.jones@linaro.org \
--cc=balbi@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=maxime.coquelin@st.com \
--cc=patrice.chotard@st.com \
--cc=peppe.cavallaro@st.com \
--cc=peter.griffin@linaro.org \
--cc=srinivas.kandagatla@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).