linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: sanjeev sharma <sanjeev_sharma@mentor.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
	waydi1@gmail.com, swetland@google.com,
	linux-kernel@vger.kernel.org, root <root@inn.mentorg.com>,
	daniel@ffwll.ch
Subject: Re: [PATCH] staging: android: Fixed missing blank line
Date: Thu, 17 Jul 2014 10:28:23 +0300	[thread overview]
Message-ID: <20140717072742.GD25880@mwanda> (raw)
In-Reply-To: <1405581524-13423-1-git-send-email-sanjeev_sharma@mentor.com>

On Thu, Jul 17, 2014 at 12:48:44PM +0530, sanjeev sharma wrote:
> From: root <root@inndt291.inn.mentorg.com>

You shouldn't be doing this stuff as root...  Also fix your From header
so that your name is capitalized on your emails.

regards,
dan carpenter


  reply	other threads:[~2014-07-17  7:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-17  7:18 [PATCH] staging: android: Fixed missing blank line sanjeev sharma
2014-07-17  7:28 ` Dan Carpenter [this message]
2014-07-18  4:47 Sanjeev Sharma
2014-07-18 23:16 ` Greg KH
2014-07-23 10:08   ` Sharma, Sanjeev
2014-07-23 15:25     ` Greg KH
2014-07-28  5:14       ` Sharma, Sanjeev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140717072742.GD25880@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=daniel@ffwll.ch \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=root@inn.mentorg.com \
    --cc=sanjeev_sharma@mentor.com \
    --cc=swetland@google.com \
    --cc=waydi1@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).