Hi, On Wed, Jul 23, 2014 at 09:16:20PM +0800, Herbert Xu wrote: > On Sat, Jul 12, 2014 at 02:59:13PM +0200, LABBE Corentin wrote: > > Add support for the Security System included in Allwinner SoC A20. > > The Security System is a hardware cryptographic accelerator that support AES/MD5/SHA1/DES/3DES/PRNG algorithms. > > > > Signed-off-by: LABBE Corentin > > This is essentially a synchronous driver, no? If so please > switch to the blkcipher/shash interface. The exact opposite has been asked for during v1's review... Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com