From: Will Deacon <will.deacon@arm.com>
To: Punit Agrawal <punit.agrawal@arm.com>
Cc: Himangi Saraogi <himangi774@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"julia.lawall@lip6.fr" <julia.lawall@lip6.fr>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] drivers: CCI: Correct use of ! and &
Date: Wed, 23 Jul 2014 16:05:18 +0100 [thread overview]
Message-ID: <20140723150518.GD27677@arm.com> (raw)
In-Reply-To: <9hhwqb42k63.fsf@arm.com>
On Wed, Jul 23, 2014 at 04:01:56PM +0100, Punit Agrawal wrote:
> > diff --git a/drivers/bus/arm-cci.c b/drivers/bus/arm-cci.c
> > index 5a86da9..7af78df 100644
> > --- a/drivers/bus/arm-cci.c
> > +++ b/drivers/bus/arm-cci.c
> > @@ -397,7 +397,8 @@ static irqreturn_t pmu_handle_irq(int irq_num, void *dev)
> > hw_counter = &event->hw;
> >
> > /* Did this counter overflow? */
> > - if (!pmu_read_register(idx, CCI_PMU_OVRFLW) & CCI_PMU_OVRFLW_FLAG)
> > + if (!(pmu_read_register(idx, CCI_PMU_OVRFLW) &
> > + CCI_PMU_OVRFLW_FLAG))
> > continue;
>
>
> Going back to the manual, this fix looks correct.
>
> Acked-by: Punit Agrawal <punit.agrawal@arm.com>
>
> Will, would this go via your tree?
Given that you're happy with it, I don't mind which tree it goes in.
Probably deserves a CC stable on it too.
If you get stuck, put it in rmk's patch system.
Will
next prev parent reply other threads:[~2014-07-23 15:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-07 14:05 [PATCH] drivers: CCI: Correct use of ! and & Himangi Saraogi
2014-07-23 15:01 ` Punit Agrawal
2014-07-23 15:05 ` Will Deacon [this message]
2014-07-29 11:34 ` Punit Agrawal
2014-07-29 16:41 ` Olof Johansson
2014-07-30 10:32 ` Punit Agrawal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140723150518.GD27677@arm.com \
--to=will.deacon@arm.com \
--cc=himangi774@gmail.com \
--cc=julia.lawall@lip6.fr \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=punit.agrawal@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).