From: "Theodore Ts'o" <tytso@mit.edu>
To: Andrey Utkin <andrey.krieger.utkin@gmail.com>
Cc: hannes@stressinduktion.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: Reading large amounts from /dev/urandom broken
Date: Wed, 23 Jul 2014 11:14:59 -0400 [thread overview]
Message-ID: <20140723151459.GA6673@thunk.org> (raw)
In-Reply-To: <CANZNk81nyws__swPUoxz912wi5PJ2CBXbiLpJ-Jc4oLcX+J8vw@mail.gmail.com>
On Wed, Jul 23, 2014 at 04:52:21PM +0300, Andrey Utkin wrote:
> Dear developers, please check bugzilla ticket
> https://bugzilla.kernel.org/show_bug.cgi?id=80981 (not the initial
> issue, but starting with comment#3.
>
> Reading from /dev/urandom gives EOF after 33554431 bytes. I believe
> it is introduced by commit 79a8468747c5f95ed3d5ce8376a3e82e0c5857fc,
> with the chunk
>
> nbytes = min_t(size_t, nbytes, INT_MAX >> (ENTROPY_SHIFT + 3));
>
> which is described in commit message as "additional paranoia check to
> prevent overly large count values to be passed into urandom_read()".
>
> I don't know why people pull such large amounts of data from urandom,
> but given today there are two bugreports regarding problems doing
> that, i consider that this is practiced.
I've inquired on the bugzilla why the reporter is abusing urandom in
this way. The other commenter on the bug replicated the problem, but
that's not a "second bug report" in my book.
At the very least, this will probably cause me to insert a warning
printk: "insane user of /dev/urandom: [current->comm] requested %d
bytes" whenever someone tries to request more than 4k.
- Ted
next prev parent reply other threads:[~2014-07-23 15:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-23 13:52 Reading large amounts from /dev/urandom broken Andrey Utkin
2014-07-23 14:32 ` Hannes Frederic Sowa
2014-07-23 15:14 ` Theodore Ts'o [this message]
2014-07-23 15:19 ` Hannes Frederic Sowa
2014-07-24 20:39 ` Alex Elsayed
2014-08-09 7:45 ` Pavel Machek
2014-08-10 11:51 ` Andrey Utkin
2014-08-12 9:14 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140723151459.GA6673@thunk.org \
--to=tytso@mit.edu \
--cc=andrey.krieger.utkin@gmail.com \
--cc=hannes@stressinduktion.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).