From: scameron@beardog.cce.hp.com
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org, xerofoify@gmail.com,
scott.benesh@hp.com, iss_storagedev@hp.com,
michael.miller@canonical.com, scameron@beardog.cce.hp.com
Subject: Re: cciss_scsi.c: Fix me
Date: Wed, 23 Jul 2014 10:19:11 -0500 [thread overview]
Message-ID: <20140723151911.GM14599@beardog.cce.hp.com> (raw)
In-Reply-To: <53CFD0A5.7010609@infradead.org>
On Wed, Jul 23, 2014 at 08:11:33AM -0700, Randy Dunlap wrote:
> On 07/23/2014 07:41 AM, scameron@beardog.cce.hp.com wrote:
> > On Wed, Jul 23, 2014 at 02:15:29PM +0000, Benesh, Scott wrote:
> >> From: Nick Krause [mailto:xerofoify@gmail.com]
> >> Sent: Saturday, July 19, 2014 11:51 PM
> >> To: mike.miller@hp.com
> >> Cc: ISS StorageDev; linux-kernel@vger.kernel.org
> >> Subject: cciss_scsi.c: Fix me
> >>
> >> Hey Mike,
> >> I seem to be hitting a fix me message in this file in function,cciss_scsi_queue_command_lck.
> >> I am wondering what you want to do when C is Null?
> >> Cheers Nick
> >
> > Hi Nick,
> >
> > Mike's moved on from HP to Canonical now.
> >
> > It looks like you're running out of commands for tape drives,
> > which shouldn't ever happen, since we set
> >
> > sh->can_queue = cciss_tape_cmds;
> >
> > and we allocate that many commands + 2....
> >
> > scsi_cmd_stack_setup(ctlr_info_t *h, struct cciss_scsi_adapter_data_t *sa)
> > {
> > int i;
> > struct cciss_scsi_cmd_stack_t *stk;
> > size_t size;
> >
> > stk = &sa->cmd_stack;
> > stk->nelems = cciss_tape_cmds + 2;
> >
> > You're apparently hitting this:
> >
> > spin_lock_irqsave(&h->lock, flags);
> > c = scsi_cmd_alloc(h);
> > spin_unlock_irqrestore(&h->lock, flags);
> > if (c == NULL) { /* trouble... */
> > dev_warn(&h->pdev->dev, "scsi_cmd_alloc returned NULL!\n");
> > /* FIXME: next 3 lines are -> BAD! <- */
> > cmd->result = DID_NO_CONNECT << 16;
> > done(cmd);
> > return 0;
> > }
> >
> > which means that scsi_cmd_alloc returned NULL, which only happens
> > if the thing has run out of commands.
> >
> > It's not obvious to me how it can be that it runs out of commands.
> > Maybe we're losing them somehow, but this has not previously been
> > a problem that I'm aware of.
> >
> > Are you able to reproduce the problem?
> >
> > What's going on on the system when it happens?
> >
> > putting in a dump_stack(); near that FIXME might give a clue.
> >
> > Which kernel are you running?
> >
> > -- steve
>
> Hi Steve,
>
> You apparently have not been following the Nick saga.
>
> Nick is using cscope to search for FIXMEs in the kernel source tree and
> then trying to generate patches to remove or 'fix' them.
>
> He is not hitting a kernel oops or panic or bug.
Ah, ok, thanks. That explains it, because I was pretty sure that
code is a "this will never happen" case.
-- steve
next prev parent reply other threads:[~2014-07-23 15:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-20 4:51 cciss_scsi.c: Fix me Nick Krause
[not found] ` <E97154CC48E26246A93194D00057266054F11A3F@G9W0745.americas.hpqcorp.net>
2014-07-23 14:41 ` scameron
2014-07-23 15:11 ` Randy Dunlap
2014-07-23 15:19 ` scameron [this message]
2014-07-23 15:38 ` Nick Krause
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140723151911.GM14599@beardog.cce.hp.com \
--to=scameron@beardog.cce.hp.com \
--cc=iss_storagedev@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.miller@canonical.com \
--cc=rdunlap@infradead.org \
--cc=scott.benesh@hp.com \
--cc=xerofoify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).