From: Greg KH <gregkh@linuxfoundation.org>
To: Sasha Levin <sasha.levin@oracle.com>
Cc: stern@rowland.harvard.edu, mail@beyermatthias.de,
hdegoede@redhat.com, sarah.a.sharp@linux.intel.com,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
rostedt@goodmis.org, Sasha Levin <sashal@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] usb-core: Revert "usb-core: Remove Fix mes in file hcd.c"
Date: Thu, 24 Jul 2014 13:56:20 -0700 [thread overview]
Message-ID: <20140724205620.GB31160@kroah.com> (raw)
In-Reply-To: <53D13255.4030004@oracle.com>
On Thu, Jul 24, 2014 at 12:20:37PM -0400, Sasha Levin wrote:
> On 07/24/2014 12:04 PM, Greg KH wrote:
> >> If you add a revert and leave the original broken commit in, wouldn't it cause issues
> >> > for anyone trying to bisect a build breakage?
> > Yes it does.
> >
> > I can not rebase my public trees, nor should any other kernel
> > maintainer. This has been true for _many_ years.
>
> This isn't the case with -mm, for example, where the tree does get edited
> quite often.
-mm is a set of quilt patches, not a git tree.
> What stops you from editing it even if people are working on it? 'git pull --rebase'
> will dtrt for both the ff and the non-ff case, where the non-ff case would have happen
> either way if those people kept tracking your -next tree.
No, subsystem maintainers are not allowed to break their trees like
this, unless something really major happens that requires it.
Again, it's been this way for years, and is one of the requirements of
subsystem maintainers. If you want a "testing" branch, use a "testing"
branch, but don't cause problems on your "real" branch or problems will
happen.
thanks,
greg k-h
prev parent reply other threads:[~2014-07-24 20:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-23 12:56 [PATCH] usb-core: Revert "usb-core: Remove Fix mes in file hcd.c" Sasha Levin
2014-07-23 16:49 ` Greg KH
2014-07-24 13:14 ` Sasha Levin
2014-07-24 16:04 ` Greg KH
2014-07-24 16:20 ` Sasha Levin
2014-07-24 20:56 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140724205620.GB31160@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mail@beyermatthias.de \
--cc=rostedt@goodmis.org \
--cc=sarah.a.sharp@linux.intel.com \
--cc=sasha.levin@oracle.com \
--cc=sashal@kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).