From: Tobias Klauser <tklauser@distanz.ch>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Ley Foon Tan <lftan@altera.com>,
Linux-Arch <linux-arch@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
Chung-Lin Tang <cltang@codesourcery.com>
Subject: Re: [PATCH v2 05/29] nios2: Memory management
Date: Wed, 30 Jul 2014 10:57:43 +0200 [thread overview]
Message-ID: <20140730085743.GC10301@distanz.ch> (raw)
In-Reply-To: <CAMuHMdWw7WGibh38OdAQEmFzV3J9-z3=B74y8i8XxNsdTvOEyw@mail.gmail.com>
On 2014-07-30 at 10:18:49 +0200, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> On Wed, Jul 30, 2014 at 8:42 AM, Ley Foon Tan <lftan@altera.com> wrote:
> > On Mon, Jul 28, 2014 at 10:59 PM, Geert Uytterhoeven
> > <geert@linux-m68k.org> wrote:
> >> On Tue, Jul 15, 2014 at 10:45 AM, Ley Foon Tan <lftan@altera.com> wrote:
> >>> --- /dev/null
> >>> +++ b/arch/nios2/include/asm/mmu.h
> >>> @@ -0,0 +1,18 @@
> >>> +/*
> >>> + * Copyright (C) 2010 Tobias Klauser <tklauser@distanz.ch>
> >>> + * Copyright (C) 2004 Microtronix Datacom Ltd.
> >>> + *
> >>> + * Taken from m68knommu.
> >>> + *
> >>> + * This file is subject to the terms and conditions of the GNU General Public
> >>> + * License. See the file "COPYING" in the main directory of this archive
> >>> + * for more details.
> >>> + */
> >>> +
> >>> +#ifndef _ASM_NIOS2_MMU_H
> >>> +#define _ASM_NIOS2_MMU_H
> >>> +
> >>> +/* Default "unsigned long" context */
> >>> +typedef unsigned long mm_context_t;
> >>> +
> >>> +#endif /* _ASM_NIOS2_MMU_H */
> >>
> >> Any chance you can use mmu.h from asm-generic instead?
> >> It uses a struct with a single "unsigned long end_brk" member (unless
> >> CONFIG_BINFMT_ELF_FDPIC is defined).
> > From asm-generic/mmu.h, it is for nommu implementations.
> > So, I will keep this as it is now.
>
> Right, you have a MMU.
> I got confused by the "Taken from m68knommu" comment, and you still
> only need a single "unsigned long".
That comment stems from the initial Nios II NOMMU port done by
Microtronix. Since Nios II NOMMU support was dropped for mainline
submission anyhow, it might be better to drop that comment to avoid any
future confusion :)
Cheers
Tobias
next prev parent reply other threads:[~2014-07-30 8:57 UTC|newest]
Thread overview: 109+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-15 8:45 [PATCH v2 00/29] nios2 Linux kernel port Ley Foon Tan
2014-07-15 8:45 ` [PATCH v2 01/29] nios2: Assembly macros and definitions Ley Foon Tan
2014-07-15 8:45 ` [PATCH v2 02/29] nios2: Kernel booting and initialization Ley Foon Tan
2014-07-30 9:12 ` Tobias Klauser
2014-07-30 10:58 ` Ley Foon Tan
2014-07-15 8:45 ` [PATCH v2 03/29] nios2: Exception handling Ley Foon Tan
2014-07-15 8:45 ` [PATCH v2 04/29] nios2: Traps exception handling Ley Foon Tan
2014-07-15 8:45 ` [PATCH v2 05/29] nios2: Memory management Ley Foon Tan
2014-07-28 14:59 ` Geert Uytterhoeven
2014-07-30 6:42 ` Ley Foon Tan
2014-07-30 8:18 ` Geert Uytterhoeven
2014-07-30 8:57 ` Tobias Klauser [this message]
2014-07-30 10:52 ` Ley Foon Tan
2014-07-30 9:01 ` Tobias Klauser
2014-07-30 10:50 ` Ley Foon Tan
2014-07-15 8:45 ` [PATCH v2 06/29] nios2: I/O Mapping Ley Foon Tan
2014-07-15 9:22 ` Arnd Bergmann
2014-07-15 10:51 ` Ley Foon Tan
2014-07-15 8:45 ` [PATCH v2 07/29] nios2: MMU Fault handling Ley Foon Tan
2014-07-15 8:45 ` [PATCH v2 08/29] nios2: Page table management Ley Foon Tan
2014-07-15 8:45 ` [PATCH v2 09/29] nios2: Process management Ley Foon Tan
2014-07-15 8:45 ` [PATCH v2 10/29] nios2: Cache handling Ley Foon Tan
2014-07-15 8:45 ` [PATCH v2 11/29] nios2: TLB handling Ley Foon Tan
2014-07-15 8:45 ` [PATCH v2 12/29] nios2: Interrupt handling Ley Foon Tan
2014-07-15 9:27 ` Arnd Bergmann
2014-07-17 6:15 ` Ley Foon Tan
2014-07-17 9:24 ` Arnd Bergmann
2014-07-17 10:48 ` Ley Foon Tan
2014-07-15 9:51 ` Thomas Gleixner
2014-07-17 6:33 ` Ley Foon Tan
2014-07-17 13:58 ` Thomas Gleixner
2014-07-18 6:55 ` Ley Foon Tan
2014-07-15 8:45 ` [PATCH v2 13/29] nios2: DMA mapping API Ley Foon Tan
2014-07-15 9:38 ` Arnd Bergmann
2014-07-24 11:37 ` Ley Foon Tan
2014-07-24 12:05 ` Arnd Bergmann
2014-07-28 15:48 ` rkuo
2014-07-30 3:42 ` Ley Foon Tan
2014-07-30 12:56 ` James Bottomley
2014-07-15 8:45 ` [PATCH v2 14/29] nios2: ELF definitions Ley Foon Tan
2014-07-15 8:45 ` [PATCH v2 15/29] nios2: System calls handling Ley Foon Tan
2014-07-18 12:56 ` James Hogan
2014-07-21 11:17 ` Ley Foon Tan
2014-07-15 8:45 ` [PATCH v2 16/29] nios2: Signal handling support Ley Foon Tan
2014-07-18 8:04 ` Richard Weinberger
2014-08-08 7:21 ` Ley Foon Tan
2014-07-15 8:45 ` [PATCH v2 17/29] nios2: Library functions Ley Foon Tan
2014-07-15 8:45 ` [PATCH v2 18/29] nios2: Device tree support Ley Foon Tan
2014-07-15 9:41 ` Arnd Bergmann
2014-07-15 10:02 ` Ley Foon Tan
2014-07-15 8:45 ` [PATCH v2 19/29] nios2: Time keeping Ley Foon Tan
2014-07-15 9:45 ` Arnd Bergmann
2014-07-21 10:07 ` Ley Foon Tan
2014-07-21 10:51 ` Arnd Bergmann
2014-07-21 11:10 ` Ley Foon Tan
2014-07-15 10:00 ` Thomas Gleixner
2014-07-21 11:09 ` Ley Foon Tan
2014-07-21 12:35 ` Thomas Gleixner
2014-07-15 8:45 ` [PATCH v2 20/29] nios2: Cpuinfo handling Ley Foon Tan
2014-07-15 9:47 ` Arnd Bergmann
2014-07-18 2:43 ` Ley Foon Tan
2014-08-07 5:06 ` Ley Foon Tan
2014-07-15 8:45 ` [PATCH v2 21/29] nios2: Futex operations Ley Foon Tan
2014-07-15 10:03 ` Thomas Gleixner
2014-07-17 10:55 ` Ley Foon Tan
2014-07-17 11:07 ` Arnd Bergmann
2014-07-18 6:07 ` Ley Foon Tan
2014-07-18 9:09 ` Arnd Bergmann
2014-07-18 9:42 ` Thomas Gleixner
2014-07-18 9:55 ` Arnd Bergmann
2014-07-21 3:20 ` Ley Foon Tan
2014-07-21 8:01 ` Arnd Bergmann
2014-07-21 10:24 ` Ley Foon Tan
2014-08-05 8:49 ` Geert Uytterhoeven
2014-07-15 8:45 ` [PATCH v2 22/29] nios2: Miscellaneous header files Ley Foon Tan
2014-07-15 10:22 ` Arnd Bergmann
2014-07-15 11:03 ` Chung-Lin Tang
2014-07-15 12:27 ` Arnd Bergmann
2014-07-18 6:15 ` Chung-Lin Tang
2014-07-18 9:18 ` Arnd Bergmann
2014-07-16 7:03 ` Ley Foon Tan
2014-07-15 8:45 ` [PATCH v2 23/29] nios2: Nios2 registers Ley Foon Tan
2014-07-15 8:45 ` [PATCH v2 24/29] nios2: Module support Ley Foon Tan
2014-07-15 10:24 ` Arnd Bergmann
2014-07-15 11:12 ` Tobias Klauser
2014-07-15 12:21 ` Arnd Bergmann
2014-07-16 1:36 ` LF.Tan
2014-07-16 1:32 ` Ley Foon Tan
2014-07-15 8:45 ` [PATCH v2 25/29] nios2: ptrace support Ley Foon Tan
2014-07-15 8:45 ` [PATCH v2 26/29] Add ELF machine define for Nios2 Ley Foon Tan
2014-07-15 9:04 ` Tobias Klauser
2014-07-15 9:40 ` Ley Foon Tan
2014-07-15 8:45 ` [PATCH v2 27/29] MAINTAINERS: Add nios2 maintainer Ley Foon Tan
2014-07-15 11:10 ` Joe Perches
2014-07-16 1:08 ` Ley Foon Tan
2014-07-15 8:45 ` [PATCH v2 28/29] Documentation: Add documentation for Nios2 architecture Ley Foon Tan
2014-07-15 8:45 ` [PATCH v2 29/29] nios2: Build infrastructure Ley Foon Tan
2014-07-16 19:50 ` Paul Bolle
2014-07-17 9:35 ` Sam Ravnborg
2014-07-15 9:08 ` [PATCH v2 00/29] nios2 Linux kernel port Tobias Klauser
2014-07-15 9:38 ` Ley Foon Tan
2014-07-15 11:15 ` Tobias Klauser
2014-07-16 1:21 ` Ley Foon Tan
2014-07-15 13:16 ` David Howells
2014-07-15 13:19 ` Richard Weinberger
2014-07-15 14:20 ` David Howells
2014-07-15 20:27 ` Richard Weinberger
2014-07-15 22:36 ` David Howells
2014-07-15 22:45 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140730085743.GC10301@distanz.ch \
--to=tklauser@distanz.ch \
--cc=cltang@codesourcery.com \
--cc=geert@linux-m68k.org \
--cc=lftan@altera.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).