From: Mark Rutland <mark.rutland@arm.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <Pawel.Moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Stephen Warren <swarren@wwwdotorg.org>,
Arnd Bergmann <arnd@arndb.de>, Will Deacon <Will.Deacon@arm.com>,
Joerg Roedel <joro@8bytes.org>,
Cho KyongHo <pullip.cho@samsung.com>,
Grant Grundler <grundler@chromium.org>,
Dave P Martin <Dave.Martin@arm.com>,
Marc Zyngier <Marc.Zyngier@arm.com>,
Hiroshi Doyu <hdoyu@nvidia.com>,
Olav Haugan <ohaugan@codeaurora.org>,
Varun Sethi <varun.sethi@freescale.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4] devicetree: Add generic IOMMU device tree bindings
Date: Thu, 31 Jul 2014 10:22:41 +0100 [thread overview]
Message-ID: <20140731092241.GA21850@leverpostej> (raw)
In-Reply-To: <20140731083923.GA31218@ulmo>
[...]
> > > +Examples:
> > > +=========
> > > +
> > > +Single-master IOMMU:
> > > +--------------------
> > > +
> > > + iommu {
> > > + #iommu-cells = <0>;
> > > + };
> > > +
> > > + master {
> > > + iommus = <&/iommu>;
> >
> > Nit: this should be iommus = <&{/iommu}>, or it's not valid dts syntax.
>
> Done.
Cheers. I take it that was done for the other occurrences too?
>
> > > + };
> > > +
> > > +Multiple-master IOMMU with fixed associations:
> > > +----------------------------------------------
> > > +
> > > + /* multiple-master IOMMU */
> > > + iommu {
> > > + /*
> > > + * Masters are statically associated with this IOMMU and
> > > + * address translation is always enabled.
> > > + */
> > > + #iommu-cells = <0>;
> >
> > I don't follow why translation being always enabled is relevant to the
> > example; that would seem to be independent from the binding.
> >
> > Surely the key point is that with no way to distinguish devices, they
> > presumably share the same translations?
>
> Both aspects are important I think. For #iommu-cells = <0> there is no
> way for the IOMMU driver to know how to enable translation for a given
> device. So it must be either always on or always off.
Sure. But "always on or off" is not the same as "always enabled", which
was what confused me.
> I guess one could say that this is implicit if all masters share the
> same translations. And I guess translations don't always have to be on
> or off technically. Let me try to rephrase this:
>
> /*
> * Masters are statically associated with this IOMMU and share
> * the same address translations because the IOMMU does not
> * have sufficient information to distinguish between masters.
> *
> * Consequently address translation is always on or off for
> * all masters at any given point in time.
> */
>
> Does that sound better?
That addresses my concern, so yes.
Given these are minor and everyone wants this in now, I'm happy for
these to go through in a fixup patch later.
Cheers,
Mark.
next prev parent reply other threads:[~2014-07-31 9:22 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-04 15:29 [PATCH v4] devicetree: Add generic IOMMU device tree bindings Thierry Reding
2014-07-09 13:40 ` Will Deacon
2014-07-09 14:21 ` Thierry Reding
2014-07-09 18:10 ` Will Deacon
2014-07-10 9:49 ` Thierry Reding
2014-07-10 10:23 ` Will Deacon
2014-07-10 10:57 ` Thierry Reding
2014-07-10 12:38 ` Will Deacon
2014-07-11 20:55 ` Rob Clark
2014-07-12 9:39 ` Will Deacon
2014-07-12 11:26 ` Rob Clark
2014-07-12 12:22 ` Arnd Bergmann
2014-07-12 12:57 ` Rob Clark
2014-07-13 9:43 ` Will Deacon
2014-07-13 11:43 ` Rob Clark
2014-07-16 1:25 ` Olav Haugan
2014-07-16 10:10 ` Will Deacon
2014-07-16 20:24 ` Rob Clark
2014-07-14 6:44 ` Thierry Reding
2014-07-14 10:08 ` Will Deacon
2014-07-14 6:24 ` Thierry Reding
2014-07-14 10:13 ` Rob Clark
2014-07-14 6:15 ` Thierry Reding
2014-07-30 11:04 ` Will Deacon
2014-07-30 13:23 ` Thierry Reding
2014-07-30 13:33 ` Joerg Roedel
2014-07-30 17:37 ` Olof Johansson
2014-07-30 14:30 ` Will Deacon
2014-07-30 18:08 ` Rob Herring
2014-07-30 20:11 ` Arnd Bergmann
2014-07-30 15:26 ` Mark Rutland
2014-07-30 17:35 ` Olof Johansson
2014-07-30 18:18 ` Mark Rutland
2014-07-31 10:09 ` Thierry Reding
2014-07-31 10:50 ` Mark Rutland
2014-07-31 11:14 ` Thierry Reding
2014-07-31 9:51 ` Thierry Reding
2014-07-31 8:39 ` Thierry Reding
2014-07-31 9:22 ` Mark Rutland [this message]
2014-07-31 10:18 ` Thierry Reding
2014-07-31 10:23 ` Joerg Roedel
2014-07-31 10:46 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140731092241.GA21850@leverpostej \
--to=mark.rutland@arm.com \
--cc=Dave.Martin@arm.com \
--cc=Marc.Zyngier@arm.com \
--cc=Pawel.Moll@arm.com \
--cc=Will.Deacon@arm.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=grundler@chromium.org \
--cc=hdoyu@nvidia.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=ohaugan@codeaurora.org \
--cc=pullip.cho@samsung.com \
--cc=robh+dt@kernel.org \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
--cc=varun.sethi@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).