From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Hugh Dickins <hughd@google.com>
Cc: Sabrina Dubroca <sd@queasysnail.net>,
Valdis.Kletnieks@vt.edu, Vincent Donnefort <vdonnefort@gmail.com>,
Bryan Wu <cooloney@gmail.com>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-wireless@vger.kernel.org
Subject: Re: 3.17-rc1: leds blink workqueue causes sleeping BUGs
Date: Tue, 26 Aug 2014 01:34:43 +0200 [thread overview]
Message-ID: <20140825233443.GB13130@type.youpi.perso.aquilenet.fr> (raw)
In-Reply-To: <alpine.LSU.2.11.1408251454570.26438@eggly.anvils>
Hugh Dickins, le Mon 25 Aug 2014 15:00:44 -0700, a écrit :
> On Mon, 25 Aug 2014, Samuel Thibault wrote:
> > Samuel Thibault, le Mon 25 Aug 2014 23:23:24 +0200, a écrit :
> > > We could indeed have a loop if the user was making the VT::* leds use
> > > the vt-* trigger,
> >
> > Actually, while there can be a loop, it wouldn't be possible to inject
> > events in it: a VT::* led only makes the corresponding vt-* trigger if
> > it got an event from its trigger, etc. So it's really a false positive,
> > the lock detector just can not know that it can not happen.
>
> I'm not suffering from this lockdep warning myself; but, false positive
> or not, it does need to be fixed (or annotated). Because once lockdep
> reports one issue, it turns itself off. So any developer who hits this
> warning is then unable test their own changes with lockdep afterwards.
Ew. I'll have a look.
Samuel
next prev parent reply other threads:[~2014-08-25 23:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-17 3:27 3.17-rc1: leds blink workqueue causes sleeping BUGs Hugh Dickins
2014-08-19 12:58 ` [PATCH] leds: make led_blink_set IRQ safe Vincent Donnefort
2014-08-19 12:58 ` Vincent Donnefort
2014-08-20 1:51 ` Hugh Dickins
2014-08-23 0:21 ` Bryan Wu
2014-08-23 17:24 ` Tejun Heo
2014-08-25 8:50 ` Vincent Donnefort
2014-08-19 17:06 ` 3.17-rc1: leds blink workqueue causes sleeping BUGs Valdis.Kletnieks
2014-08-25 21:13 ` Sabrina Dubroca
2014-08-25 21:23 ` Samuel Thibault
2014-08-25 21:37 ` Samuel Thibault
2014-08-25 22:00 ` Hugh Dickins
2014-08-25 23:34 ` Samuel Thibault [this message]
[not found] <541FD018.107@gmail.com>
2014-09-22 7:37 ` Samuel Thibault
2014-09-22 9:37 ` Kari Suvanto
2014-09-22 7:42 Kari Suvanto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140825233443.GB13130@type.youpi.perso.aquilenet.fr \
--to=samuel.thibault@ens-lyon.org \
--cc=Valdis.Kletnieks@vt.edu \
--cc=cooloney@gmail.com \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=sd@queasysnail.net \
--cc=vdonnefort@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).