From: Eduardo Valentin <edubezval@gmail.com>
To: Chanwoo Choi <cw00.choi@samsung.com>
Cc: eduardo.valentin@ti.com, amit.daniel@samsung.com,
rui.zhang@intel.com, kgene.kim@samsung.com,
ch.naveen@samsung.com, kyungmin.park@samsung.com,
b.zolnierkie@samsung.com, linux-pm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv5 4/4] thermal: exynos: Remove duplicate code when reading triminfo register of Exynos5440
Date: Thu, 28 Aug 2014 10:53:12 -0400 [thread overview]
Message-ID: <20140828145310.GC18194@developer> (raw)
In-Reply-To: <53FEAF2A.1080400@samsung.com>
On Thu, Aug 28, 2014 at 01:25:14PM +0900, Chanwoo Choi wrote:
> Dear Eduardo,
>
> This patch is wrong. It is my mistake.
>
> Please ignore only this patch because
> the offset calculation of 'case 0' is different from 'case 2'.
Do patches 1 - 3 are still correct? Patch 1, from Barlomiej, seams to be
a common agreement.
>
> Best Regards,
> Chanwoo Choi
>
> On 08/26/2014 10:31 AM, Chanwoo Choi wrote:
> > This patch remove simply duplicate code when reading triminfo register of Exynos5440.
> >
> > Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> > Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
> > Cc: Zhang Rui <rui.zhang@intel.com>
> > Cc: Eduardo Valentin <edubezval@gmail.com>
> > Cc: Amit Daniel Kachhap <amit.daniel@samsung.com>
> > Reviewed-by: Amit Daniel Kachhap <amit.daniel@samsung.com>
> > ---
> > drivers/thermal/samsung/exynos_tmu.c | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c
> > index 64c702a..5888467 100644
> > --- a/drivers/thermal/samsung/exynos_tmu.c
> > +++ b/drivers/thermal/samsung/exynos_tmu.c
> > @@ -187,15 +187,13 @@ static int exynos_tmu_initialize(struct platform_device *pdev)
> > */
> > switch (data->id) {
> > case 0:
> > + case 2:
> > trim_info = readl(data->base +
> > EXYNOS5440_EFUSE_SWAP_OFFSET + reg->triminfo_data);
> > break;
> > case 1:
> > trim_info = readl(data->base + reg->triminfo_data);
> > break;
> > - case 2:
> > - trim_info = readl(data->base -
> > - EXYNOS5440_EFUSE_SWAP_OFFSET + reg->triminfo_data);
> > }
> > } else {
> > /* On exynos5420 the triminfo register is in the shared space */
> >
>
next prev parent reply other threads:[~2014-08-28 14:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-26 1:31 [PATCHv5 0/4] thermal: exynos: Add support for TRIMINFO feature of Exynos3250 Chanwoo Choi
2014-08-26 1:31 ` [PATCHv5 1/4] thermal: samsung: Exynos5260 and Exynos5420 should not use TRIM_RELOAD flag Chanwoo Choi
2014-08-26 1:31 ` [PATCHv5 2/4] thermal: exynos: Add support for many TRIMINFO_CTRL registers Chanwoo Choi
2014-08-26 1:31 ` [PATCHv5 3/4] thermal: exynos: Add support for TRIM_RELOAD feature at Exynos3250 Chanwoo Choi
2014-08-26 1:31 ` [PATCHv5 4/4] thermal: exynos: Remove duplicate code when reading triminfo register of Exynos5440 Chanwoo Choi
2014-08-28 4:25 ` Chanwoo Choi
2014-08-28 14:53 ` Eduardo Valentin [this message]
2014-08-28 23:50 ` Chanwoo Choi
2014-08-29 19:28 ` Eduardo Valentin
2014-09-03 2:08 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140828145310.GC18194@developer \
--to=edubezval@gmail.com \
--cc=amit.daniel@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=ch.naveen@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=eduardo.valentin@ti.com \
--cc=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).