From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753498AbaIAMdQ (ORCPT ); Mon, 1 Sep 2014 08:33:16 -0400 Received: from mail-pd0-f172.google.com ([209.85.192.172]:53812 "EHLO mail-pd0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752638AbaIAMdO (ORCPT ); Mon, 1 Sep 2014 08:33:14 -0400 From: Shakil A Khan To: Johannes Berg Subject: Re: [PATCH 2/2] nl80211.c: Fixed the wdev_id being used uninitialized. Date: Mon, 1 Sep 2014 08:33:10 -0400 User-Agent: KMail/1.12.4 (Linux/3.17.0-rc1+; KDE/4.3.4; x86_64; ; ) Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, davem@davemloft.net, linville@tuxdriver.com References: <1409572467-50908-1-git-send-email-shakilk1729@gmail.com> <1409573258.2703.0.camel@jlt4.sipsolutions.net> In-Reply-To: <1409573258.2703.0.camel@jlt4.sipsolutions.net> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201409010833.10647.shakilk1729@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 01 September 2014 08:07:38 Johannes Berg wrote: > > + u64 wdev_id = 0; > > it's not used uninitialized, NACK. > > johannes > wdev_id can be used uninitialized if have_wdev_id turns to be false, which may happen if the entry for NL80211_ATTR_WDEV is removed in future. Who knows.