From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: Chen Gang <gang.chen.5i5j@gmail.com>
Cc: <eparis@redhat.com>, <paulmck@linux.vnet.ibm.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
<zhenglong.cai@cs2c.com.cn>, <khilman@linaro.org>,
<ak@linux.intel.com>, <mcgrof@suse.com>, <fabf@skynet.be>,
"dhowells@redhat.com" <dhowells@redhat.com>,
<pefoley2@pefoley.com>, <mgorman@suse.de>, <biederm@xmission.com>,
"hpa@zytor.com" <hpa@zytor.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>, Jean Delvare <jdelvare@suse.de>
Subject: Re: [PATCH] init/Kconfig: Add ENDIAN attributes for all architectures using
Date: Mon, 1 Sep 2014 12:08:29 -0400 [thread overview]
Message-ID: <20140901160828.GJ26632@windriver.com> (raw)
In-Reply-To: <540494D6.40701@gmail.com>
[[PATCH] init/Kconfig: Add ENDIAN attributes for all architectures using] On 01/09/2014 (Mon 23:46) Chen Gang wrote:
> Some individual modules want to know the architecture's endian attribute
> during config time, or may cause compiling break, one sample is below:
> (with allm dconfig under microblaze):
>
> CC [M] drivers/isdn/hisax/nj_s.o
> drivers/isdn/hisax/nj_s.c: In function 'setup_netjet_s':
> drivers/isdn/hisax/nj_s.c:265:2: error: #error "not running on big endian machines now"
> #error "not running on big endian machines now"
>
> So add endian attributes for all architectures using (next, will let all
> architectures choose their endians during config time).
>
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> ---
> init/Kconfig | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/init/Kconfig b/init/Kconfig
> index ac033c3..f301cc8 100644
> --- a/init/Kconfig
> +++ b/init/Kconfig
> @@ -23,6 +23,12 @@ config CONSTRUCTORS
> config IRQ_WORK
> bool
>
> +config CPU_LITTLE_ENDIAN
> + bool
> +
> +config CPU_BIG_ENDIAN
> + bool
Perhaps you should take a cursory look at what already exists in tree
before blindly trying to add more to it?
$ git grep CPU_BIG_ENDIAN | wc -l
88
Paul.
--
> +
> config BUILDTIME_EXTABLE_SORT
> bool
>
> --
> 1.7.11.7
next prev parent reply other threads:[~2014-09-01 16:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-01 15:46 [PATCH] init/Kconfig: Add ENDIAN attributes for all architectures using Chen Gang
2014-09-01 16:08 ` Paul Gortmaker [this message]
2014-09-01 17:01 ` H. Peter Anvin
2014-09-02 1:44 ` Chen Gang
2014-09-02 5:17 ` Paul Gortmaker
2014-09-02 6:13 ` Chen Gang
2014-09-03 11:47 ` Chen Gang
2014-09-14 9:08 ` Chen Gang
2014-09-15 13:55 ` Arnd Bergmann
2014-09-15 22:41 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140901160828.GJ26632@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=biederm@xmission.com \
--cc=dhowells@redhat.com \
--cc=eparis@redhat.com \
--cc=fabf@skynet.be \
--cc=gang.chen.5i5j@gmail.com \
--cc=geert@linux-m68k.org \
--cc=hpa@zytor.com \
--cc=jdelvare@suse.de \
--cc=khilman@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@suse.com \
--cc=mgorman@suse.de \
--cc=paulmck@linux.vnet.ibm.com \
--cc=pefoley2@pefoley.com \
--cc=zhenglong.cai@cs2c.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).