From: An Tuan Ha <zero579911@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/12] Staging: rtl8821ae: hal_bt_coexist: fix commenting style
Date: Tue, 2 Sep 2014 07:22:12 -0400 [thread overview]
Message-ID: <20140902112212.GA2048@DARE> (raw)
In-Reply-To: <20140902091939.GB6600@mwanda>
I see, thanks, I will fix it, I was just worried about the subjects
being too long so I just stuck with the same subject; is there a
character limit on how long the subject line should be? Or as long as
it's reasonable, it'll be fine?
On Tue, Sep 02, 2014 at 12:19:40PM +0300, Dan Carpenter wrote:
> Hm... Now you've broken it into *too* many separate patches. Also the
> subjects are the same. Also the subjects are too vague. Which coding
> style issue is addressed?
>
> It should be something like:
> patch 1: comments
> patch 2: add/remove spaces
> patch 3: fix quoted text
> patch 4: braces
> patch 5: add a blank line
>
> regards,
> dan carpenter
>
next prev parent reply other threads:[~2014-09-02 11:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-02 0:29 [PATCH 01/12] Staging: rtl8821ae: hal_bt_coexist: fix commenting style An Ha
2014-09-02 0:29 ` [PATCH 02/12] Staging: rtl8821ae: hal_bt_coexist: fix coding style issue An Ha
2014-09-02 0:29 ` [PATCH 03/12] " An Ha
2014-09-02 0:29 ` [PATCH 04/12] " An Ha
2014-09-02 0:29 ` [PATCH 05/12] Staging: rtl8821ae: hal_bt_coexist: fix pointer placement " An Ha
2014-09-02 0:29 ` [PATCH 06/12] Staging: rtl8821ae: hal_bt_coexist: fix " An Ha
2014-09-02 0:29 ` [PATCH 07/12] " An Ha
2014-09-02 0:29 ` [PATCH 08/12] " An Ha
2014-09-02 0:29 ` [PATCH 09/12] " An Ha
2014-09-02 0:29 ` [PATCH 10/12] " An Ha
2014-09-02 0:29 ` [PATCH 11/12] " An Ha
2014-09-02 0:29 ` [PATCH 12/12] " An Ha
2014-09-02 9:19 ` [PATCH 01/12] Staging: rtl8821ae: hal_bt_coexist: fix commenting style Dan Carpenter
2014-09-02 11:22 ` An Tuan Ha [this message]
2014-09-02 13:35 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140902112212.GA2048@DARE \
--to=zero579911@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).