From: Rafael Aquini <aquini@redhat.com>
To: Konstantin Khlebnikov <koct9i@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Konstantin Khlebnikov <k.khlebnikov@samsung.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org, Andrey Ryabinin <ryabinin.a.a@gmail.com>,
Sasha Levin <sasha.levin@oracle.com>
Subject: Re: [PATCH v2 1/6] mm/balloon_compaction: ignore anonymous pages
Date: Tue, 2 Sep 2014 08:29:28 -0400 [thread overview]
Message-ID: <20140902122927.GB14419@t510.redhat.com> (raw)
In-Reply-To: <20140830164109.29066.46373.stgit@zurg>
On Sat, Aug 30, 2014 at 08:41:09PM +0400, Konstantin Khlebnikov wrote:
> From: Konstantin Khlebnikov <k.khlebnikov@samsung.com>
>
> Sasha Levin reported KASAN splash inside isolate_migratepages_range().
> Problem is in function __is_movable_balloon_page() which tests AS_BALLOON_MAP
> in page->mapping->flags. This function has no protection against anonymous
> pages. As result it tried to check address space flags in inside anon-vma.
>
> Signed-off-by: Konstantin Khlebnikov <k.khlebnikov@samsung.com>
> Reported-by: Sasha Levin <sasha.levin@oracle.com>
> Link: http://lkml.kernel.org/p/53E6CEAA.9020105@oracle.com
> Cc: stable <stable@vger.kernel.org> # v3.8
> ---
> include/linux/balloon_compaction.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/balloon_compaction.h b/include/linux/balloon_compaction.h
> index 089743a..53d482e 100644
> --- a/include/linux/balloon_compaction.h
> +++ b/include/linux/balloon_compaction.h
> @@ -128,7 +128,7 @@ static inline bool page_flags_cleared(struct page *page)
> static inline bool __is_movable_balloon_page(struct page *page)
> {
> struct address_space *mapping = page->mapping;
> - return mapping_balloon(mapping);
> + return !PageAnon(page) && mapping_balloon(mapping);
> }
>
> /*
>
Acked-by: Rafael Aquini <aquini@redhat.com>
next prev parent reply other threads:[~2014-09-02 12:29 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-30 16:41 [PATCH v2 0/6] mm/balloon_compaction: fixes and cleanups Konstantin Khlebnikov
2014-08-30 16:41 ` [PATCH v2 1/6] mm/balloon_compaction: ignore anonymous pages Konstantin Khlebnikov
2014-09-02 12:29 ` Rafael Aquini [this message]
2014-08-30 16:41 ` [PATCH v2 2/6] mm/balloon_compaction: keep ballooned pages away from normal migration path Konstantin Khlebnikov
2014-09-02 12:31 ` Rafael Aquini
2014-08-30 16:41 ` [PATCH v2 3/6] mm/balloon_compaction: isolate balloon pages without lru_lock Konstantin Khlebnikov
2014-09-02 12:32 ` Rafael Aquini
2014-08-30 16:41 ` [PATCH v2 4/6] mm: introduce common page state for ballooned memory Konstantin Khlebnikov
2014-09-02 12:53 ` Rafael Aquini
2014-09-12 23:51 ` Andrew Morton
2014-09-13 5:26 ` Konstantin Khlebnikov
2014-09-13 5:42 ` Andrew Morton
2014-09-13 8:22 ` Konstantin Khlebnikov
2014-09-19 21:35 ` Andrew Morton
2014-09-20 5:25 ` Konstantin Khlebnikov
2014-09-20 6:23 ` Andrew Morton
2014-09-22 18:40 ` Konstantin Khlebnikov
2014-09-22 19:22 ` Rafael Aquini
2014-09-22 20:06 ` Konstantin Khlebnikov
2014-09-22 20:22 ` Rafael Aquini
2014-09-22 20:46 ` Konstantin Khlebnikov
2014-09-13 14:03 ` Sasha Levin
2014-08-30 16:41 ` [PATCH v2 5/6] mm/balloon_compaction: use common page ballooning Konstantin Khlebnikov
2014-09-02 12:57 ` Rafael Aquini
2014-09-12 23:57 ` Andrew Morton
2014-08-30 16:41 ` [PATCH v2 6/6] mm/balloon_compaction: general cleanup Konstantin Khlebnikov
2014-09-02 13:09 ` Rafael Aquini
2014-09-13 0:04 ` Andrew Morton
2014-09-13 0:06 ` Andrew Morton
2014-09-13 5:43 ` Konstantin Khlebnikov
2014-09-13 0:09 ` [PATCH v2 0/6] mm/balloon_compaction: fixes and cleanups Andrew Morton
2014-09-13 5:01 ` Konstantin Khlebnikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140902122927.GB14419@t510.redhat.com \
--to=aquini@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=k.khlebnikov@samsung.com \
--cc=koct9i@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ryabinin.a.a@gmail.com \
--cc=sasha.levin@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).