From: Peter Zijlstra <peterz@infradead.org>
To: "Rustad, Mark D" <mark.d.rustad@intel.com>
Cc: "Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>,
"mingo@redhat.com" <mingo@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] semaphore: Resolve some shadow warnings
Date: Wed, 3 Sep 2014 11:39:50 +0200 [thread overview]
Message-ID: <20140903093950.GE4783@worktop.ger.corp.intel.com> (raw)
In-Reply-To: <176C5670-03A7-4003-925D-9C252A7A284F@intel.com>
On Tue, Sep 02, 2014 at 09:16:23PM +0000, Rustad, Mark D wrote:
>
> It would, but then it would be unclear as to what units the timeout
> was in. I have no other objection to timeout, I was just trying to
> preserve the meaning in the existing overloaded name. The "n" to me
> suggests a number and, if anything, number of jiffies conveys a more
> precise meaning than simply jiffies did.
Use a comment for the unit. If you look you'll find tons of 'timeout'
variables that measure in jiffies (and others of course).
prev parent reply other threads:[~2014-09-03 9:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-28 12:19 [PATCH] semaphore: Resolve some shadow warnings Jeff Kirsher
2014-09-01 12:02 ` Peter Zijlstra
2014-09-01 23:41 ` Jeff Kirsher
2014-09-02 21:16 ` Rustad, Mark D
2014-09-03 9:39 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140903093950.GE4783@worktop.ger.corp.intel.com \
--to=peterz@infradead.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.d.rustad@intel.com \
--cc=mingo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).