From: Boris BREZILLON <boris.brezillon@free-electrons.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Pankaj Dubey <pankaj.dubey@samsung.com>,
kgene.kim@samsung.com, linux@arm.linux.org.uk,
Alexander Shiyan <shc_work@mail.ru>,
naushad@samsung.com, Tomasz Figa <t.figa@samsung.com>,
linux-kernel@vger.kernel.org, joshi@samsung.com,
linux-samsung-soc@vger.kernel.org, thomas.ab@samsung.com,
tomasz.figa@gmail.com, vikas.sajjan@samsung.com,
chow.kim@samsung.com, lee.jones@linaro.org,
Michal Simek <michal.simek@xilinx.com>,
linux-arm-kernel@lists.infradead.org,
Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH v2] mfd: syscon: Decouple syscon interface from platform devices
Date: Wed, 3 Sep 2014 16:15:28 +0200 [thread overview]
Message-ID: <20140903161528.05f566e1@bbrezillon> (raw)
In-Reply-To: <4224773.hl3QDeILqz@wuerfel>
On Wed, 03 Sep 2014 15:49:04 +0200
Arnd Bergmann <arnd@arndb.de> wrote:
> On Wednesday 03 September 2014 15:16:11 Boris BREZILLON wrote:
> > I checked that part, and it appears most of the code is already there
> > (see usage of regmap_attach_dev function here [1]).
> >
> > The only problem I see is that errors are still printed with dev_err,
> > which, AFAIK, will trigger a kernel panic if dev is NULL.
>
> Actually not:
>
> static int __dev_printk(const char *level, const struct device *dev,
> struct va_format *vaf)
> {
> if (!dev)
> return printk("%s(NULL device *): %pV", level, vaf);
>
> return dev_printk_emit(level[1] - '0', dev,
> "%s %s: %pV",
> dev_driver_string(dev), dev_name(dev), vaf);
> }
>
My bad then (I don't know where I looked at to think NULL dev was not
gracefully handled :-)). Thanks for pointing this out.
Given that, I think it should work fine even with a NULL dev.
I'll give it a try on at91 ;-).
Best Regards,
Boris
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-09-03 14:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-02 14:42 [PATCH v2] mfd: syscon: Decouple syscon interface from platform devices Pankaj Dubey
2014-09-02 14:50 ` Tomasz Figa
2014-09-02 15:20 ` Arnd Bergmann
2014-09-02 15:42 ` Alexander Shiyan
2014-09-02 17:40 ` Arnd Bergmann
2014-09-03 13:16 ` Boris BREZILLON
2014-09-03 13:49 ` Arnd Bergmann
2014-09-03 14:15 ` Boris BREZILLON [this message]
2014-09-04 4:45 ` Pankaj Dubey
2014-09-04 6:03 ` Boris BREZILLON
2014-09-05 8:14 ` Boris BREZILLON
2014-09-16 11:53 ` Pankaj Dubey
2014-09-16 14:52 ` Arnd Bergmann
2014-09-04 4:39 ` Pankaj Dubey
2014-09-04 4:52 ` Alexander Shiyan
2014-09-03 3:44 ` Vivek Gautam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140903161528.05f566e1@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=chow.kim@samsung.com \
--cc=joshi@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=michal.simek@xilinx.com \
--cc=naushad@samsung.com \
--cc=pankaj.dubey@samsung.com \
--cc=shc_work@mail.ru \
--cc=t.figa@samsung.com \
--cc=thomas.ab@samsung.com \
--cc=tomasz.figa@gmail.com \
--cc=vikas.sajjan@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).