From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753526AbaIESxJ (ORCPT ); Fri, 5 Sep 2014 14:53:09 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:54697 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751488AbaIESxG (ORCPT ); Fri, 5 Sep 2014 14:53:06 -0400 Date: Fri, 05 Sep 2014 11:53:05 -0700 (PDT) Message-Id: <20140905.115305.809714259412705649.davem@davemloft.net> To: sd@queasysnail.net Cc: hannes@stressinduktion.org, cwang@twopensource.com, tt.rantala@gmail.com, kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, trinity@vger.kernel.org, davej@redhat.com Subject: Re: [PATCH net v2] ipv6: fix rtnl locking in setsockopt for anycast and multicast From: David Miller In-Reply-To: <20140902082929.GA8483@kria> References: <20140901210520.GB25543@kria> <1409610378.21965.52.camel@localhost> <20140902082929.GA8483@kria> X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.7 (shards.monkeyblade.net [149.20.54.216]); Fri, 05 Sep 2014 11:53:06 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sabrina Dubroca Date: Tue, 2 Sep 2014 10:29:29 +0200 > Calling setsockopt with IPV6_JOIN_ANYCAST or IPV6_LEAVE_ANYCAST > triggers the assertion in addrconf_join_solict()/addrconf_leave_solict() > > ipv6_sock_ac_join(), ipv6_sock_ac_drop(), ipv6_sock_ac_close() need to > take RTNL before calling ipv6_dev_ac_inc/dec. Same thing with > ipv6_sock_mc_join(), ipv6_sock_mc_drop(), ipv6_sock_mc_close() before > calling ipv6_dev_mc_inc/dec. > > This patch moves ASSERT_RTNL() up a level in the call stack. > > Signed-off-by: Cong Wang > Signed-off-by: Sabrina Dubroca > Reported-by: Tommi Rantala Applied and queued up for -stable, thanks.