From: Peter Zijlstra <peterz@infradead.org>
To: Andreea-Cristina Bernat <bernat.ada@gmail.com>
Cc: paulus@samba.org, mingo@redhat.com, acme@kernel.org,
linux-kernel@vger.kernel.org, paulmck@linux.vnet.ibm.com
Subject: Re: [PATCH] kernel: events: core: Replace rcu_assign_pointer() with RCU_INIT_POINTER()
Date: Tue, 9 Sep 2014 11:42:35 +0200 [thread overview]
Message-ID: <20140909094235.GD19379@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20140822132605.GA20130@ada>
[-- Attachment #1: Type: text/plain, Size: 1991 bytes --]
On Fri, Aug 22, 2014 at 04:26:05PM +0300, Andreea-Cristina Bernat wrote:
> The use of "rcu_assign_pointer()" is NULLing out the pointer.
> According to RCU_INIT_POINTER()'s block comment:
> "1. This use of RCU_INIT_POINTER() is NULLing out the pointer"
> it is better to use it instead of rcu_assign_pointer() because it has a
> smaller overhead.
>
> The following Coccinelle semantic patch was used:
> @@
> @@
>
> - rcu_assign_pointer
> + RCU_INIT_POINTER
> (..., NULL)
>
> Signed-off-by: Andreea-Cristina Bernat <bernat.ada@gmail.com>
> ---
> kernel/events/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/events/core.c b/kernel/events/core.c
> index 0d735be..4b84dd5 100644
> --- a/kernel/events/core.c
> +++ b/kernel/events/core.c
> @@ -5744,7 +5744,7 @@ static void swevent_hlist_release(struct swevent_htable *swhash)
> if (!hlist)
> return;
>
> - rcu_assign_pointer(swhash->swevent_hlist, NULL);
> + RCU_INIT_POINTER(swhash->swevent_hlist, NULL);
> kfree_rcu(hlist, rcu_head);
> }
Paul, why not do something like the below and do away with all this
nonsense?
---
include/linux/rcupdate.h | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/include/linux/rcupdate.h b/include/linux/rcupdate.h
index d231aa17b1d7..38c3e629ae70 100644
--- a/include/linux/rcupdate.h
+++ b/include/linux/rcupdate.h
@@ -623,7 +623,13 @@ static inline void rcu_preempt_sleep_check(void)
* please be careful when making changes to rcu_assign_pointer() and the
* other macros that it invokes.
*/
-#define rcu_assign_pointer(p, v) smp_store_release(&p, RCU_INITIALIZER(v))
+#define rcu_assign_pointer(p, v) \
+do { \
+ if (__builtin_constant_p(v) && v == NULL) \
+ p = RCU_INITIALIZER(v); \
+ else \
+ smp_store_release(&p, RCU_INITIALIZER(v)); \
+} while (0)
/**
* rcu_access_pointer() - fetch RCU pointer with no dereferencing
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-09-09 9:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-22 13:26 [PATCH] kernel: events: core: Replace rcu_assign_pointer() with RCU_INIT_POINTER() Andreea-Cristina Bernat
2014-09-09 9:42 ` Peter Zijlstra [this message]
2014-09-09 16:16 ` Paul E. McKenney
2014-09-10 13:12 ` Peter Zijlstra
2014-09-12 16:30 ` Paul E. McKenney
2014-09-26 14:53 ` Peter Zijlstra
2014-09-28 7:36 ` Paul E. McKenney
2014-09-09 14:53 ` [tip:perf/core] perf/core: " tip-bot for Andreea-Cristina Bernat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140909094235.GD19379@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@kernel.org \
--cc=bernat.ada@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).