From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757001AbaIIPWS (ORCPT ); Tue, 9 Sep 2014 11:22:18 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:59333 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753099AbaIIPWN (ORCPT ); Tue, 9 Sep 2014 11:22:13 -0400 Date: Tue, 9 Sep 2014 16:21:14 +0100 From: Mark Brown To: Timur Tabi Cc: Shengjiu Wang , nicoleotsuka@gmail.com, Li.Xiubo@freescale.com, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.de, alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Message-ID: <20140909152114.GA2601@sirena.org.uk> References: <540EFDFF.7050804@tabi.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="7A15IXT36zwL5BDA" Content-Disposition: inline In-Reply-To: <540EFDFF.7050804@tabi.org> X-Cookie: Exercise caution in your daily affairs. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 109.152.174.147 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH V1] ASoC: fsl_ssi: refine ipg clock usage in this module X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --7A15IXT36zwL5BDA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Sep 09, 2014 at 08:17:51AM -0500, Timur Tabi wrote: > Shengjiu Wang wrote: > >+ if (ssi_private->soc->imx) > >+ clk_prepare_enable(ssi_private->clk); > How about this instead? > if (ssi_private->clk) > clk_prepare_enable(ssi_private->clk); Should be a !IS_ERR() - NULL is a valid clock. --7A15IXT36zwL5BDA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJUDxrmAAoJECTWi3JdVIfQGHQH/iYPDA+Ux7C65f6IB8MrMaBa UekhxwGPUW+ixAdaweL1z04umskGJbbJHRbxkaFFyWi15lzF6KLN+ntWwxg7qpld H7yUxhQixGWicLewybTFxSj5TMId8yNmbuC3pXDEn9eRz46F1MHwznSCcuEP4ueA dsxAUoapO6cieCphAljMKOL/UEVOUmLbYCnpaVF/sOJThVY+IWWzZHVhjPqCiXx3 2VXxbK5VG9bZRWirapyOV2O54iFWKtcVGxsZKmDieMj32YzVMtDPn15qsAk+2trZ ESajHSwBg45/QLRejykIoJC5Y+p3AeaWRmB48Hwb6SV+Z9udzliEf2+EblvVEbA= =xkyN -----END PGP SIGNATURE----- --7A15IXT36zwL5BDA--