From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: "Fu, Zhonghui" <zhonghui.fu@linux.intel.com>
Cc: rjw@rjwysocki.net, lenb@kernel.org, linux-acpi@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ACPI / platform / LPSS: disable async suspend/resume of LPSS devices
Date: Wed, 10 Sep 2014 10:50:26 +0300 [thread overview]
Message-ID: <20140910075026.GB13406@lahna.fi.intel.com> (raw)
In-Reply-To: <540E91F0.2060306@linux.intel.com>
On Tue, Sep 09, 2014 at 01:36:48PM +0800, Fu, Zhonghui wrote:
> >From 6deb00230f5df68da3ca7490402a0c537bf386bb Mon Sep 17 00:00:00 2001
> From: Fu Zhonghui <zhonghui.fu@linux.intel.com>
> Date: Tue, 9 Sep 2014 13:02:25 +0800
> Subject: [PATCH] ACPI / platform / LPSS: disable async suspend/resume of LPSS devices
>
> LPSS devices must suspend/resume in fixed order. Or some LPSS devices
> will hang during the transition to ACPI_STATE_D0 state.
In addition to the comment from Rafael, I would like to have more
details here why we must suspend/resume the LPSS devices in certain
order.
>
> Signed-off-by: Li Aubrey <aubrey.li@linux.intel.com>
> Signed-off-by: Fu Zhonghui <zhonghui.fu@linux.intel.com>
> ---
> drivers/acpi/acpi_lpss.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/acpi/acpi_lpss.c b/drivers/acpi/acpi_lpss.c
> index fddc1e8..54e5c97 100644
> --- a/drivers/acpi/acpi_lpss.c
> +++ b/drivers/acpi/acpi_lpss.c
> @@ -419,7 +419,7 @@ static int acpi_lpss_create_device(struct acpi_device *adev,
> adev->driver_data = pdata;
> pdev = acpi_create_platform_device(adev);
> if (!IS_ERR_OR_NULL(pdev)) {
> - device_enable_async_suspend(&pdev->dev);
> + device_disable_async_suspend(&pdev->dev);
> return 1;
> }
>
> -- 1.7.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-09-10 7:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-09 5:36 [PATCH] ACPI / platform / LPSS: disable async suspend/resume of LPSS devices Fu, Zhonghui
2014-09-09 13:17 ` Rafael J. Wysocki
2014-09-12 17:40 ` Fu, Zhonghui
2014-09-10 7:50 ` Mika Westerberg [this message]
2014-09-12 17:53 ` Fu, Zhonghui
2014-09-14 16:52 ` Rafael J. Wysocki
[not found] ` <54184C92.7060209@linux.intel.com>
[not found] ` <54203616.2040803@linux.intel.com>
2014-09-22 23:17 ` Rafael J. Wysocki
[not found] ` <5422E0FA.5090600@linux.intel.com>
2014-09-24 20:32 ` Rafael J. Wysocki
2014-09-25 2:07 ` Li, Aubrey
2014-09-25 20:08 ` Rafael J. Wysocki
2014-09-26 3:54 ` Li, Aubrey
2014-09-26 14:06 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140910075026.GB13406@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=zhonghui.fu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).