From: Gleb Natapov <gleb@kernel.org>
To: tangchen <tangchen@cn.fujitsu.com>
Cc: mtosatti@redhat.com, nadav.amit@gmail.com, jan.kiszka@web.de,
kvm@vger.kernel.org, laijs@cn.fujitsu.com,
isimatu.yasuaki@jp.fujitsu.com, guz.fnst@cn.fujitsu.com,
linux-kernel@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v4 4/6] kvm, mem-hotplug: Reload L1' apic access page on migration in vcpu_enter_guest().
Date: Wed, 10 Sep 2014 17:01:01 +0300 [thread overview]
Message-ID: <20140910140100.GE25317@minantech.com> (raw)
In-Reply-To: <540EA883.9060206@cn.fujitsu.com>
On Tue, Sep 09, 2014 at 03:13:07PM +0800, tangchen wrote:
> Hi Gleb,
>
> On 09/03/2014 11:04 PM, Gleb Natapov wrote:
> >On Wed, Sep 03, 2014 at 09:42:30AM +0800, tangchen wrote:
> >>Hi Gleb,
> >>
> >>On 09/03/2014 12:00 AM, Gleb Natapov wrote:
> >>>......
> >>>+static void vcpu_reload_apic_access_page(struct kvm_vcpu *vcpu)
> >>>+{
> >>>+ /*
> >>>+ * apic access page could be migrated. When the page is being migrated,
> >>>+ * GUP will wait till the migrate entry is replaced with the new pte
> >>>+ * entry pointing to the new page.
> >>>+ */
> >>>+ vcpu->kvm->arch.apic_access_page = gfn_to_page(vcpu->kvm,
> >>>+ APIC_DEFAULT_PHYS_BASE >> PAGE_SHIFT);
> >>>+ kvm_x86_ops->set_apic_access_page_addr(vcpu->kvm,
> >>>+ page_to_phys(vcpu->kvm->arch.apic_access_page));
> >>>I am a little bit worried that here all vcpus write to vcpu->kvm->arch.apic_access_page
> >>>without any locking. It is probably benign since pointer write is atomic on x86. Paolo?
> >>>
> >>>Do we even need apic_access_page? Why not call
> >>> gfn_to_page(APIC_DEFAULT_PHYS_BASE >> PAGE_SHIFT)
> >>> put_page()
> >>>on rare occasions we need to know its address?
> >>Isn't it a necessary item defined in hardware spec ?
> >>
> >vcpu->kvm->arch.apic_access_page? No. This is internal kvm data structure.
> >
> >>I didn't read intel spec deeply, but according to the code, the page's
> >>address is
> >>written into vmcs. And it made me think that we cannnot remove it.
> >>
> >We cannot remove writing of apic page address into vmcs, but this is not done by
> >assigning to vcpu->kvm->arch.apic_access_page, but by vmwrite in set_apic_access_page_addr().
>
> OK, I'll try to remove kvm->arch.apic_access_page and send a patch for it
> soon.
>
> BTW, if you don't have objection to the first two patches, would you please
> help to
> commit them first ?
>
I acked them and CCed Paolo to this reply. I hope he will look at the series too.
--
Gleb.
next prev parent reply other threads:[~2014-09-10 14:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-27 10:17 [PATCH v4 0/6] kvm, mem-hotplug: Do not pin ept identity pagetable and apic access page Tang Chen
2014-08-27 10:17 ` [PATCH v4 1/6] kvm: Use APIC_DEFAULT_PHYS_BASE macro as the apic access page address Tang Chen
2014-09-10 13:57 ` Gleb Natapov
2014-08-27 10:17 ` [PATCH v4 2/6] kvm: Remove ept_identity_pagetable from struct kvm_arch Tang Chen
2014-09-10 13:58 ` Gleb Natapov
2014-08-27 10:17 ` [PATCH v4 3/6] kvm: Make init_rmode_identity_map() return 0 on success Tang Chen
2014-08-27 10:17 ` [PATCH v4 4/6] kvm, mem-hotplug: Reload L1' apic access page on migration in vcpu_enter_guest() Tang Chen
2014-09-02 16:00 ` Gleb Natapov
2014-09-03 1:42 ` tangchen
2014-09-03 15:04 ` Gleb Natapov
2014-09-09 7:13 ` tangchen
2014-09-10 14:01 ` Gleb Natapov [this message]
2014-08-27 10:17 ` [PATCH v4 5/6] kvm, mem-hotplug: Reload L1's apic access page on migration when L2 is running Tang Chen
2014-09-03 1:48 ` tangchen
2014-09-03 15:08 ` Gleb Natapov
2014-08-27 10:17 ` [PATCH v4 6/6] kvm, mem-hotplug: Do not pin apic access page in memory Tang Chen
2014-09-01 5:14 ` [PATCH v4 0/6] kvm, mem-hotplug: Do not pin ept identity pagetable and apic access page tangchen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140910140100.GE25317@minantech.com \
--to=gleb@kernel.org \
--cc=guz.fnst@cn.fujitsu.com \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=jan.kiszka@web.de \
--cc=kvm@vger.kernel.org \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=nadav.amit@gmail.com \
--cc=pbonzini@redhat.com \
--cc=tangchen@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).