From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752145AbaIKFWk (ORCPT ); Thu, 11 Sep 2014 01:22:40 -0400 Received: from mail-pd0-f171.google.com ([209.85.192.171]:41045 "EHLO mail-pd0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752042AbaIKFWi (ORCPT ); Thu, 11 Sep 2014 01:22:38 -0400 Date: Thu, 11 Sep 2014 14:22:30 +0900 From: Gyungoh Yoo To: Mark Brown Cc: lgirdwood@gmail.com, grant.likely@linaro.org, robh+dt@kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Gyungoh Yoo Subject: Re: [PATCH v2.2 2/2] dt-bindings: Adding compatible attribute for SKY81452 regulator Message-ID: <20140911052230.GA3764@jack-ThinkPad-T520> References: <20140813190423.GI17528@sirena.org.uk> <1409539218-5571-1-git-send-email-jack.yoo@skyworksinc.com> <1409539218-5571-3-git-send-email-jack.yoo@skyworksinc.com> <20140901103158.GO29327@sirena.org.uk> <20140905015507.GA2636@jack-ThinkPad-T520> <20140906143828.GJ2601@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20140906143828.GJ2601@sirena.org.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Sep 06, 2014 at 03:38:28PM +0100, Mark Brown wrote: > On Fri, Sep 05, 2014 at 10:55:07AM +0900, Gyungoh Yoo wrote: > > On Mon, Sep 01, 2014 at 11:31:58AM +0100, Mark Brown wrote: > > > > Why is this a good idea - can this driver be used for anything other > > > than a sky81452? > > > Yes. There is a possibility that this driver will be used by similar > > device with SKY81452. > > OK, so tha was slightly the wrong question. What added information is > forcing the user to create a subnode and specify a compatible string > providing? This driver is specifying a block of multiple regulators > with absolute register addresses hard coded into it, there's no real > ability to use the driver in a different configuration here. As soon as > we see the parent device we already know everything there is to know > about the IP block, having a separate compatible string just forces the > user to do more typing for no gain. Thank you for your comments. By the way, I knew that compatible string is used for binding a driver. http://devicetree.org/Device_Tree_Usage#Understanding_the_compatible_Property And, from kernel 3.6, MFD core has a mechanism for binding of_node to the driver with of_compatible. Can I have a question about if it is possible to assign compatible string for binding driver independently with reusability? Thanks, Gyungoh