From: Aaron Tomlin <atomlin@redhat.com>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: peterz@infradead.org, dzickus@redhat.com, jcastillo@redhat.com,
riel@redhat.com, x86@kernel.org, akpm@linux-foundation.org,
minchan@kernel.org, bmr@redhat.com, prarit@redhat.com,
oleg@redhat.com, rostedt@goodmis.org,
linux-kernel@vger.kernel.org, hannes@cmpxchg.org,
mingo@redhat.com, aneesh.kumar@linux.vnet.ibm.com,
akpm@google.com, jgh@redhat.com, linuxppc-dev@lists.ozlabs.org,
tglx@linutronix.de, pzijlstr@redhat.com
Subject: Re: [PATCH v3 3/3] sched: BUG when stack end location is over written
Date: Fri, 12 Sep 2014 10:44:19 +0100 [thread overview]
Message-ID: <20140912094419.GD1873@atomlin.usersys.redhat.com> (raw)
In-Reply-To: <1410494817.17540.4.camel@concordia>
On Fri, Sep 12, 2014 at 02:06:57PM +1000, Michael Ellerman wrote:
> On Thu, 2014-09-11 at 16:41 +0100, Aaron Tomlin wrote:
> > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> > index a285900..2a8280a 100644
> > --- a/lib/Kconfig.debug
> > +++ b/lib/Kconfig.debug
> > @@ -824,6 +824,18 @@ config SCHEDSTATS
> > application, you can say N to avoid the very slight overhead
> > this adds.
> >
> > +config SCHED_STACK_END_CHECK
> > + bool "Detect stack corruption on calls to schedule()"
> > + depends on DEBUG_KERNEL
> > + default y
>
> Did you really mean default y?
>
> Doing so means it will be turned on more or less everywhere, which defeats the
> purpose of having a config option in the first place.
Only if Kconfig CONFIG_DEBUG_KERNEL is enabled in the first place.
--
Aaron Tomlin
next prev parent reply other threads:[~2014-09-12 9:47 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-04 14:50 [PATCH 0/2] sched: Always check the integrity of the canary Aaron Tomlin
2014-09-04 14:50 ` [PATCH 1/2] sched: Add helper for task stack page overrun checking Aaron Tomlin
2014-09-04 15:02 ` Oleg Nesterov
2014-09-04 15:52 ` Aaron Tomlin
2014-09-04 15:30 ` Peter Zijlstra
2014-09-04 14:50 ` [PATCH 2/2] sched: BUG when stack end location is over written Aaron Tomlin
2014-09-04 15:32 ` Peter Zijlstra
2014-09-04 16:11 ` Aaron Tomlin
2014-09-08 19:23 ` [PATCH v2 0/3] sched: Always check the integrity of the canary Aaron Tomlin
2014-09-08 19:23 ` [PATCH 1/3] init/main.c: Give init_task a canary Aaron Tomlin
2014-09-08 19:23 ` [PATCH 2/3] sched: Add helper for task stack page overrun checking Aaron Tomlin
2014-09-08 19:23 ` [PATCH 3/3] sched: BUG when stack end location is over written Aaron Tomlin
2014-09-09 9:42 ` [PATCH v2 0/3] sched: Always check the integrity of the canary Aaron Tomlin
2014-09-09 9:42 ` [PATCH v2 1/3] init/main.c: Give init_task a canary Aaron Tomlin
2014-09-10 7:26 ` Chuck Ebbert
2014-09-10 13:29 ` Aaron Tomlin
2014-09-11 12:23 ` Chuck Ebbert
2014-09-11 14:47 ` Aaron Tomlin
2014-09-09 9:42 ` [PATCH v2 2/3] sched: Add helper for task stack page overrun checking Aaron Tomlin
2014-09-09 9:42 ` [PATCH v2 3/3] sched: BUG when stack end location is over written Aaron Tomlin
2014-09-11 15:41 ` [PATCH v3 0/3] sched: Always check the integrity of the canary Aaron Tomlin
2014-09-11 15:41 ` [PATCH v3 1/3] init/main.c: Give init_task a canary Aaron Tomlin
2014-09-12 7:28 ` Michael Ellerman
2014-09-11 15:41 ` [PATCH v3 2/3] sched: Add helper for task stack page overrun checking Aaron Tomlin
2014-09-11 15:41 ` [PATCH v3 3/3] sched: BUG when stack end location is over written Aaron Tomlin
2014-09-12 4:06 ` Michael Ellerman
2014-09-12 9:44 ` Aaron Tomlin [this message]
2014-09-12 10:58 ` Mike Galbraith
2014-09-15 2:39 ` Michael Ellerman
2014-09-12 6:04 ` Michael Ellerman
2014-09-12 9:50 ` Aaron Tomlin
2014-09-11 15:53 ` [PATCH v3 0/3] sched: Always check the integrity of the canary Peter Zijlstra
2014-09-11 15:59 ` Aaron Tomlin
2014-09-11 16:02 ` David Laight
2014-09-11 17:26 ` Chuck Ebbert
2014-09-12 8:43 ` David Laight
2014-09-11 17:44 ` Aaron Tomlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140912094419.GD1873@atomlin.usersys.redhat.com \
--to=atomlin@redhat.com \
--cc=akpm@google.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=bmr@redhat.com \
--cc=dzickus@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=jcastillo@redhat.com \
--cc=jgh@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=minchan@kernel.org \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=prarit@redhat.com \
--cc=pzijlstr@redhat.com \
--cc=riel@redhat.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).