From: Grant Likely <grant.likely@linaro.org>
To: Stephen Boyd <sboyd@codeaurora.org>,
Stanimir Varbanov <svarbanov@mm-sol.com>
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
Rob Herring <robherring2@gmail.com>,
Rob Herring <rob.herring@linaro.org>,
Arnd Bergmann <arnd@arndb.de>, Lee Jones <lee.jones@linaro.org>,
Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH] RFC: add function for localbus address
Date: Sat, 13 Sep 2014 21:46:10 -0700 [thread overview]
Message-ID: <20140914044610.913E9C4102A@trevor.secretlab.ca> (raw)
In-Reply-To: <540E1014.8090102@codeaurora.org>
On Mon, 08 Sep 2014 13:22:44 -0700, Stephen Boyd <sboyd@codeaurora.org> wrote:
> Adding Mark Brown who finished off introducing IORESOURCE_REG.
>
> On 09/08/14 07:52, Grant Likely wrote:
> > On Tue, 2 Sep 2014 18:45:00 +0300, Stanimir Varbanov <svarbanov@mm-sol.com> wrote:
> >> +
> >> unsigned long __weak pci_address_to_pio(phys_addr_t address)
> >> {
> >> if (address > IO_SPACE_LIMIT)
> >> @@ -665,6 +691,29 @@ int of_address_to_resource(struct device_node *dev, int index,
> >> }
> >> EXPORT_SYMBOL_GPL(of_address_to_resource);
> >>
> >> +int of_localbus_address_to_resource(struct device_node *dev, int index,
> >> + struct resource *r)
> >> +{
> >> + const char *name = NULL;
> >> + const __be32 *addrp;
> >> + u64 size;
> >> +
> >> + addrp = of_get_localbus_address(dev, index, &size);
> >> + if (!addrp)
> >> + return -EINVAL;
> >> +
> >> + of_property_read_string_index(dev, "reg-names", index, &name);
> >> +
> >> + memset(r, 0, sizeof(*r));
> >> + r->start = be32_to_cpup(addrp);
> >> + r->end = r->start + size - 1;
> >> + r->flags = IORESOURCE_REG;
> > This is problematic. A resource is created, but there is absolutely no
> > indication that the resource represents a localbus address instead of a
> > CPU address. platform_device reg resources represent CPU addresses.
> > Trying to overload it will cause confusion in drivers.
> >
> >> + r->name = name ? name : dev->full_name;
> >> +
> >> + return 0;
> >> +}
> >> +EXPORT_SYMBOL_GPL(of_localbus_address_to_resource);
> >> +
> >> struct device_node *of_find_matching_node_by_address(struct device_node *from,
> >> const struct of_device_id *matches,
> >> u64 base_address)
> >> diff --git a/drivers/of/platform.c b/drivers/of/platform.c
> >> index 0197725..36dcbd7 100644
> >> --- a/drivers/of/platform.c
> >> +++ b/drivers/of/platform.c
> >> @@ -106,8 +106,9 @@ struct platform_device *of_device_alloc(struct device_node *np,
> >> struct device *parent)
> >> {
> >> struct platform_device *dev;
> >> - int rc, i, num_reg = 0, num_irq;
> >> + int rc, i, num_reg = 0, num_localbus_reg = 0, num_irq;
> >> struct resource *res, temp_res;
> >> + int num_resources;
> >>
> >> dev = platform_device_alloc("", -1);
> >> if (!dev)
> >> @@ -116,22 +117,33 @@ struct platform_device *of_device_alloc(struct device_node *np,
> >> /* count the io and irq resources */
> >> while (of_address_to_resource(np, num_reg, &temp_res) == 0)
> >> num_reg++;
> >> +
> >> + while (of_localbus_address_to_resource(np,
> >> + num_localbus_reg, &temp_res) == 0)
> >> + num_localbus_reg++;
> >> +
> > No, I don't support doing this. The moment a platform_driver depends on
> > a local bus address it is doing something special. It needs to decode
> > its own address in that case, which it can easily do.
> >
> > Any platform_driver that interprets a IORESOURCE_REG as a localbus
> > address instead of a CPU address is *BROKEN*. It should be changed to
> > either decode the address itself, of a new bus type should be created
> > that can make its own decisions about what address resources mean.
>
> Where is this described? From the commit text that introduces
> IORESOURCE_REG I see:
>
> "Currently a bunch of I2C/SPI MFD drivers are using IORESOURCE_IO for
> register address ranges. Since this causes some confusion due to the
> primary use of this resource type for PCI/ISA I/O ports create a new
> resource type IORESOURCE_REG."
Sorry, I mistook IORESOURCE_REG or IORESOURCE_IO. You're right, this
isn't an issue.
I'm still concerned about the implications of automatically populating
platform_devices with this resource type. I'll talk to Mark about it
face to fact at Connect this week.
g.
next prev parent reply other threads:[~2014-09-14 7:33 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-29 11:42 use IORESOURCE_REG resource type for non-translatable addresses in DT Stanimir Varbanov
2014-07-29 12:00 ` Arnd Bergmann
2014-07-29 14:06 ` Stanimir Varbanov
2014-07-29 15:29 ` Rob Herring
2014-07-29 23:45 ` Grant Likely
2014-07-30 1:07 ` Stephen Boyd
2014-07-30 2:53 ` Rob Herring
2014-07-30 6:06 ` Stephen Boyd
2014-08-27 16:27 ` Stanimir Varbanov
2014-08-27 18:24 ` Bjorn Andersson
2014-08-27 21:55 ` Stephen Boyd
2014-08-29 4:09 ` Bjorn Andersson
2014-08-28 7:58 ` Stanimir Varbanov
2014-09-02 15:45 ` [PATCH] RFC: add function for localbus address Stanimir Varbanov
2014-09-05 23:29 ` Stephen Boyd
2014-09-08 14:52 ` Grant Likely
2014-09-08 20:22 ` Stephen Boyd
2014-09-08 21:21 ` Mark Brown
2014-09-14 4:46 ` Grant Likely [this message]
2014-10-22 23:01 ` Stephen Boyd
2014-10-22 23:20 ` Russell King - ARM Linux
2014-10-22 23:53 ` Stephen Boyd
2014-10-22 23:51 ` Mark Brown
2014-09-09 15:07 ` Stanimir Varbanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140914044610.913E9C4102A@trevor.secretlab.ca \
--to=grant.likely@linaro.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rob.herring@linaro.org \
--cc=robherring2@gmail.com \
--cc=sboyd@codeaurora.org \
--cc=svarbanov@mm-sol.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).