From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753154AbaIOCKr (ORCPT ); Sun, 14 Sep 2014 22:10:47 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:45086 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753001AbaIOCKq (ORCPT ); Sun, 14 Sep 2014 22:10:46 -0400 Date: Sun, 14 Sep 2014 19:09:57 -0700 From: Greg Kroah-Hartman To: One Thousand Gnomes Cc: Mark S , linux-kernel@vger.kernel.org, Octavian Purdila , Jun Tian , Alan Cox Subject: Re: 3.15 Regression Due to goldfish bus Commit Message-ID: <20140915020957.GA8203@kroah.com> References: <20140914215737.GA945@kroah.com> <20140915001219.63fb91dd@alan.etchedpixels.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140915001219.63fb91dd@alan.etchedpixels.co.uk> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 15, 2014 at 12:12:19AM +0100, One Thousand Gnomes wrote: > On Sun, 14 Sep 2014 14:57:37 -0700 > Greg Kroah-Hartman wrote: > > > On Sun, Sep 14, 2014 at 05:38:55PM -0400, Mark S wrote: > > > Commit c1bc97f8f498a2bfab63ceef761fb0e88ef7c065 causes a gateway x86 laptop, > > > booting from a usb device, to hang before the kernel completes booting. The > > > offending commit was found using git bisect. Reverting the commit fixes the > > > problem on 3.16.2. > > > > > > The error resulting in the hang may not be a concern since the goldfish option > > > is not needed and should probably not be selected. I'm mentioning this problem > > > just in case it is unexpected behavior and it is worth fixing. Maybe the > > > goldfish option should not be selectable for a similar configuration as mine? > > > > There should be some other type of run-time option to not have this code > > run if it is found to not be running on the goldfish virtual machine. > > > > Anyone know how to do that? > > I asked last time it was reported and the time before (it comes up every > year or two). There is no sane documented way to detect the Goldfish > virtual machine as distinct from anything else. > > We could hide Goldfish under expert ? No, that would be a mess. Just put a big warning on the option, no one should be enabling it if they don't want it, the config option text should say this. thanks, greg k-h