linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH 2/2] virtio-rng: fix stuck in catting hwrng attributes
       [not found]           ` <20140915164846.GA29862@potion.brq.redhat.com>
@ 2014-09-16  0:50             ` Amos Kong
  0 siblings, 0 replies; only message in thread
From: Amos Kong @ 2014-09-16  0:50 UTC (permalink / raw)
  To: Radim Krčmář
  Cc: Rusty Russell, virtualization, kvm, amit.shah, jasowang,
	linux-kernel, m, herbert, mpm

CC linux-kernel

Original thread: http://comments.gmane.org/gmane.linux.kernel.virtualization/22775

On Mon, Sep 15, 2014 at 06:48:46PM +0200, Radim Krčmář wrote:
> 2014-09-14 10:25+0800, Amos Kong:
> > On Sun, Sep 14, 2014 at 09:12:08AM +0800, Amos Kong wrote:
> > 
> > ...
> > > > > > diff --git a/drivers/char/hw_random/core.c b/drivers/char/hw_random/core.c
> > > > > > index c591d7e..b5d1b6f 100644
> > > > > > --- a/drivers/char/hw_random/core.c
> > > > > > +++ b/drivers/char/hw_random/core.c
> > > > > > @@ -195,8 +195,7 @@ static ssize_t rng_dev_read(struct file *filp, char __user *buf,
> > > > > >  
> > > > > >  		mutex_unlock(&rng_mutex);
> > > > > >  
> > > > > > -		if (need_resched())
> > > > > > -			schedule_timeout_interruptible(1);
> > > > > > +		schedule_timeout_interruptible(10);
> 
> If cond_resched() does not work, it is a bug elsewehere.

Thanks for your reply, Jason also told me the TIF_NEED_RESCHED should
be set in this case, then need_resched() returns true.

I will investigate the issue and reply you later.
 
> > Problem only occurred in non-smp guest, we can improve it to:
> > 
> >                         if(!is_smp())
> >                                 schedule_timeout_interruptible(10);
> > 
> > is_smp() is only available for arm arch, we need a general one.
> 
> (It is num_online_cpus() > 1.)

-- 
			Amos.

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2014-09-16  0:51 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <1410340027-15373-1-git-send-email-akong@redhat.com>
     [not found] ` <1410340027-15373-3-git-send-email-akong@redhat.com>
     [not found]   ` <8738byie04.fsf@rustcorp.com.au>
     [not found]     ` <20140913171258.GB12276@zen.redhat.com>
     [not found]       ` <20140914011208.GA1032@zen.redhat.com>
     [not found]         ` <20140914022553.GC1032@zen.redhat.com>
     [not found]           ` <20140915164846.GA29862@potion.brq.redhat.com>
2014-09-16  0:50             ` [PATCH 2/2] virtio-rng: fix stuck in catting hwrng attributes Amos Kong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).