From: Masahiro Yamada <yamada.m@jp.panasonic.com>
To: Brian Norris <computersforpeace@gmail.com>
Cc: linux-mtd@lists.infradead.org,
Rashika Kheria <rashika.kheria@gmail.com>,
linux-kernel@vger.kernel.org, Huang Shijie <shijie8@gmail.com>,
Jiri Kosina <trivial@kernel.org>,
David Woodhouse <dwmw2@infradead.org>,
"grmoore@altera.com" <grmoore@altera.com>,
Josh Triplett <josh@joshtriplett.org>
Subject: Re: [PATCH v2 0/7] mtd: denali: A collection of trivial coding style fixes
Date: Tue, 16 Sep 2014 11:11:58 +0900 [thread overview]
Message-ID: <20140916111154.58F0.AA925319@jp.panasonic.com> (raw)
In-Reply-To: <20140916003620.GA1193@ld-irv-0074>
Hi Brian,
On Mon, 15 Sep 2014 17:36:20 -0700
Brian Norris <computersforpeace@gmail.com> wrote:
> On Tue, Sep 09, 2014 at 11:01:50AM +0900, Masahiro Yamada wrote:
> > Changes in v2:
> > - Join quotes strings into a single line
> >
> > Masahiro Yamada (7):
> > mtd: denali: fix the format of comment blocks
> > mtd: denali: remove unnecessary variable initializations
> > mtd: denali: remove unnecessary casts
> > mtd: denali: change the type of iterators to int
> > mtd: denali: remove a set-but-unused variable
> > mtd: denali: remove unnecessary parentheses
> > mtd: denali: fix indents and other trivial things
> >
> > drivers/mtd/nand/denali.c | 562 +++++++++++++++++++++++++---------------------
> > 1 file changed, 303 insertions(+), 259 deletions(-)
>
> Pushed patches 1 to 5 to l2-mtd.git. Thanks!
>
> Patch 6 has a conflict with another fix already in l2-mtd.git. Can you
> rebase and resend?
Sorry for my ignorance, but where can I find l2-mtd.git?
In my understanding, the subsystem repositories should be documented
in MAINTAINERS, so I looked for it but just found
T: git git://git.infradead.org/linux-mtd.git.
I do not think it is the one you mentioned.
> BTW, my automatic build tests show that there's at least one other
> 'unused' warning left, in case you want to tackle it too:
>
> drivers/mtd/nand/denali.c: In function ‘denali_read_page_raw’:
> drivers/mtd/nand/denali.c:1221:11: warning: variable ‘irq_status’ set but not used [-Wunused-but-set-variable]
> uint32_t irq_status;
>
You are right.
(What is odd enough is this warning was not displayed on my build test.
I do not know why.)
Is there a chance for me to resend 5/7 to include this fix?
Or is it too late?
Best Regards
Masahiro Yamada
next prev parent reply other threads:[~2014-09-16 2:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-09 2:01 [PATCH v2 0/7] mtd: denali: A collection of trivial coding style fixes Masahiro Yamada
2014-09-09 2:01 ` [PATCH v2 1/7] mtd: denali: fix the format of comment blocks Masahiro Yamada
2014-09-09 2:01 ` [PATCH v2 2/7] mtd: denali: remove unnecessary variable initializations Masahiro Yamada
2014-09-09 2:01 ` [PATCH v2 3/7] mtd: denali: remove unnecessary casts Masahiro Yamada
2014-09-09 2:01 ` [PATCH v2 4/7] mtd: denali: change the type of iterators to int Masahiro Yamada
2014-09-09 2:01 ` [PATCH v2 5/7] mtd: denali: remove a set-but-unused variable Masahiro Yamada
2014-09-09 2:01 ` [PATCH v2 6/7] mtd: denali: remove unnecessary parentheses Masahiro Yamada
2014-09-09 2:01 ` [PATCH v2 7/7] mtd: denali: fix indents and other trivial things Masahiro Yamada
2014-09-16 0:36 ` [PATCH v2 0/7] mtd: denali: A collection of trivial coding style fixes Brian Norris
2014-09-16 2:11 ` Masahiro Yamada [this message]
2014-09-16 5:07 ` Brian Norris
2014-09-16 11:08 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140916111154.58F0.AA925319@jp.panasonic.com \
--to=yamada.m@jp.panasonic.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=grmoore@altera.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=rashika.kheria@gmail.com \
--cc=shijie8@gmail.com \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).