From: Lee Jones <lee.jones@linaro.org>
To: micky <micky_ching@realsil.com.cn>
Cc: sameo@linux.intel.com, devel@linuxdriverproject.org,
linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
rogerable@realtek.com, wei_wang@realsil.com.cn
Subject: Re: [PATCH] mfd: rtsx: fix PM suspend for 5227 & 5249
Date: Thu, 18 Sep 2014 17:21:01 -0700 [thread overview]
Message-ID: <20140919002101.GB29852@lee--X1> (raw)
In-Reply-To: <541A7286.1080008@realsil.com.cn>
On Thu, 18 Sep 2014, micky wrote:
> On 09/18/2014 12:53 PM, Lee Jones wrote:
> >On Thu, 18 Sep 2014, micky_ching@realsil.com.cn wrote:
> >
> >>From: Micky Ching <micky_ching@realsil.com.cn>
> >>
> >>Fix rts5227&5249 failed send buffer cmd after suspend,
> >>PM_CTRL3 should reset before send any buffer cmd after suspend.
> >>Otherwise, buffer cmd will failed, this will lead resume fail.
> >>
> >>Signed-off-by: Micky Ching <micky_ching@realsil.com.cn>
> >>---
> >> drivers/mfd/rts5227.c | 19 +++++++++++++++++++
> >> drivers/mfd/rts5249.c | 4 ++++
> >> drivers/mfd/rtsx_pcr.h | 1 +
> >> include/linux/mfd/rtsx_pci.h | 12 ++++++++++++
> >> 4 files changed, 36 insertions(+)
> >I think you'll find you just broke the build.
> >
> >What happens when you compile these as modules?
> I build as modules with no warning or error, did you find anything wrong?
Yes, you don't export the functions.
EXPORT_SYMBOL()
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-09-19 0:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-18 1:35 [PATCH] mfd: rtsx: fix PM suspend for 5227 & 5249 micky_ching
2014-09-18 4:53 ` Lee Jones
2014-09-18 5:49 ` micky
2014-09-19 0:21 ` Lee Jones [this message]
2014-09-19 1:24 ` micky
2014-09-18 6:55 micky_ching
2014-10-06 21:05 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140919002101.GB29852@lee--X1 \
--to=lee.jones@linaro.org \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=micky_ching@realsil.com.cn \
--cc=rogerable@realtek.com \
--cc=sameo@linux.intel.com \
--cc=wei_wang@realsil.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).