From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756979AbaISNgl (ORCPT ); Fri, 19 Sep 2014 09:36:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:64089 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755682AbaISNgj (ORCPT ); Fri, 19 Sep 2014 09:36:39 -0400 Date: Fri, 19 Sep 2014 14:34:15 +0100 From: Aaron Tomlin To: mingo@kernel.org Cc: Chuck Ebbert , Helge Deller , linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org, linux-metag , James Hogan Subject: Re: [PATCH] Fix end_of_stack() fn and location of stack canary for archs using STACK_GROWSUP Message-ID: <20140919133415.GG25400@atomlin.usersys.redhat.com> References: <20140916023736.49db964e@as> <541C11C1.2060105@imgtec.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <541C11C1.2060105@imgtec.com> X-PGP-Key: http://pgp.mit.edu/pks/lookup?search=atomlin%40redhat.com X-PGP-Fingerprint: 7906 84EB FA8A 9638 8D1E 6E9B E2DE 9658 19CC 77D6 User-Agent: Mutt/1.5.22.1 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 19, 2014 at 12:21:37PM +0100, James Hogan wrote: > Hi Chuck, > > On 16/09/14 08:37, Chuck Ebbert wrote: > > static inline unsigned long *end_of_stack(struct task_struct *p) > > { > > +#ifdef CONFIG_STACK_GROWSUP > > + return (unsigned long *)((unsigned long)task_thread_info(p) + THREAD_SIZE) - 1; > > Nit: this line should probably be wrapped to 80 columns. > > Other than that, I've tested this on metag and can confirm that it fixes > the following BUG which you would otherwise get during boot with Aaron's > patches: > > BUG: failure at kernel/sched/core.c:2664/schedule_debug()! > Kernel panic - not syncing: BUG! > > Tested-by: James Hogan [metag] > Acked-by: James Hogan OK. Acked-by: Aaron Tomlin > Aaron: please can you try to get this patch applied before your patch > series. Ingo, I hope it's not too late to get this patch in (once the nit has been addressed) for CONFIG_STACK_GROWSUP? Regards, -- Aaron Tomlin