From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Daniel Mack <daniel@zonque.org>
Cc: Matt Ranostay <mranostay@gmail.com>,
galak@codeaurora.org, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org, robh+dt@kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 2/3] cap1106: support for active-high interrupt option
Date: Sun, 21 Sep 2014 22:56:56 -0700 [thread overview]
Message-ID: <20140922055656.GA4147@core.coreip.homeip.net> (raw)
In-Reply-To: <541EA326.1070404@zonque.org>
On Sun, Sep 21, 2014 at 12:06:30PM +0200, Daniel Mack wrote:
> On 09/21/2014 05:01 AM, Matt Ranostay wrote:
> > Some applications need to use the active-high push-pull interrupt
> > option. This allows it be enabled in the device tree child node.
> >
> > Signed-off-by: Matt Ranostay <mranostay@gmail.com>
> > ---
> > drivers/input/keyboard/cap1106.c | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/drivers/input/keyboard/cap1106.c b/drivers/input/keyboard/cap1106.c
> > index b9c43b5..33e2590 100644
> > --- a/drivers/input/keyboard/cap1106.c
> > +++ b/drivers/input/keyboard/cap1106.c
> > @@ -234,6 +234,12 @@ static int cap1106_i2c_probe(struct i2c_client *i2c_client,
> > dev_err(dev, "Invalid sensor-gain value %d\n", gain32);
> > }
> >
> > + if (of_property_read_bool(node, "microchip,active-high")) {
>
> I think the name of that property should make clear it's only changing
> the interrupt output driver configuration. What about
> "microchip,irq-active-high"?
Can we infer the setting from IRQ flags by chance?
Thanks.
--
Dmitry
next prev parent reply other threads:[~2014-09-22 5:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-21 3:01 [PATCH 0/3] cap1106: add support for cap11xx variants Matt Ranostay
2014-09-21 3:01 ` [PATCH 1/3] cap1106: Add support for various cap11xx devices Matt Ranostay
2014-09-21 9:58 ` Daniel Mack
2014-09-21 22:46 ` Matt Ranostay
2014-09-22 7:36 ` Daniel Mack
2014-09-22 0:28 ` Matt Ranostay
2014-09-22 5:59 ` Dmitry Torokhov
2014-09-21 10:53 ` Daniel Mack
2014-09-21 3:01 ` [PATCH 2/3] cap1106: support for active-high interrupt option Matt Ranostay
2014-09-21 10:06 ` Daniel Mack
2014-09-22 5:56 ` Dmitry Torokhov [this message]
2014-09-22 7:44 ` Daniel Mack
2014-09-21 3:01 ` [PATCH 3/3] dt: cap1106 active-high property addition Matt Ranostay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140922055656.GA4147@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=daniel@zonque.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mranostay@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).