Re: [PATCHSET 0/5] perf tools: Add call-graph config options

[Jiri Olsa <jolsa@redhat.com>]

On Sun, Sep 21, 2014 at 01:18:01AM +0900, Namhyung Kim wrote:
> Hello,
> 
> This is patchset to add new callchain related config options so that
> users don't need to pass their preference to the cmdline everytime.
> 
> Following config options will be added, and users can set appropriate
> values to ~/.perfconfig file.  Note that the dump-size option is
> meaningful only if record-mode = dwarf.
> 
>   $ cat ~/.perfconfig
>   [call-graph]
>     record-mode = dwarf
>     dump-size = 4096
>     print-type = graph
>     order = callee
>     threshold = 0.5
>     print-limit = 128
>     sort-key = function
> 
>   $ perf record -vg sleep 1
>   callchain: type DWARF
>   callchain: stack dump size 4096
>   mmap size 528384B
>   [ perf record: Woken up 1 times to write data ]
>   [ perf record: Captured and wrote 0.054 MB perf.data (~2378 samples) ]
>   Looking at the vmlinux_path (7 entries long)
>   Using /lib/modules/3.16.3-1-ARCH/build/vmlinux for symbols
> 
> 
> You can also get this from 'perf/callchain-config-v1' branch on my tree
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git
> 
> 
> Any comments are welcomed, thanks
> Namhyung
> 
> 
> Namhyung Kim (5):
>   perf hists browser: Fix callchain print bug on TUI
>   perf tools: Move callchain config from record_opts to callchain_param
>   perf tools: Move some callchain parser functions to callchain.c
>   perf tools: Introduce perf_callchain_config()
>   perf tools: Convert {record,top}.call-graph option to
>     call-graph.record-mode

apart from my other comments, for the patchset:

Acked-by: Jiri Olsa <jolsa@kernel.org>

thanks,
jirka