From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755485AbaIWKl7 (ORCPT ); Tue, 23 Sep 2014 06:41:59 -0400 Received: from mail-lb0-f176.google.com ([209.85.217.176]:49185 "EHLO mail-lb0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754381AbaIWKl5 (ORCPT ); Tue, 23 Sep 2014 06:41:57 -0400 X-Google-Original-Sender: Date: Tue, 23 Sep 2014 12:39:23 +0200 From: Johan Hovold To: Nicolas Ferre Cc: Boris BREZILLON , Alexandre Belloni , Alessandro Zummo , rtc-linux@googlegroups.com, Johan Hovold , Jean-Christophe Plagniol-Villard , Andrew Victor , Samuel Ortiz , Lee Jones , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 06/10] rtc: at91sam9: rework the Kconfig description Message-ID: <20140923103923.GB404@localhost> References: <1411465130-29011-1-git-send-email-boris.brezillon@free-electrons.com> <1411465130-29011-7-git-send-email-boris.brezillon@free-electrons.com> <542146AF.3060807@atmel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <542146AF.3060807@atmel.com> User-Agent: Mutt/1.5.22 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 23, 2014 at 12:08:47PM +0200, Nicolas Ferre wrote: > On 23/09/2014 11:38, Boris BREZILLON : > > Remove all references to AT91CAP9 SoC which has been removed. > > Rework the help message to remove any specific references to AT91SAM9 SoCs. > > > > Signed-off-by: Boris BREZILLON > > --- > > drivers/rtc/Kconfig | 17 +++++++++-------- > > 1 file changed, 9 insertions(+), 8 deletions(-) > > > > diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig > > index 7d76da8..455f2c3 100644 > > --- a/drivers/rtc/Kconfig > > +++ b/drivers/rtc/Kconfig > > @@ -1079,17 +1079,18 @@ config RTC_DRV_AT91RM9200 > > this is powered by the backup power supply. > > > > config RTC_DRV_AT91SAM9 > > - tristate "AT91SAM9x/AT91CAP9 RTT as RTC" > > + tristate "AT91SAM9 RTT as RTC" > > depends on ARCH_AT91 && !(ARCH_AT91RM9200 || ARCH_AT91X40) > > select MFD_SYSCON > > help > > - RTC driver for the Atmel AT91SAM9x and AT91CAP9 internal RTT > > - (Real Time Timer). These timers are powered by the backup power > > - supply (such as a small coin cell battery), but do not need to > > - be used as RTCs. > > - > > - (On AT91SAM9rl and AT91SAM9G45 chips you probably want to use the > > - dedicated RTC module and leave the RTT available for other uses.) > > + Some AT91SAM9 SoCs provide an RTT (Real Time Timer) block which > > + can be used as an RTC thanks to the backup power supply (e.g. a > > + small coin cell battery) which keeps this block and the GPBR > > + (General Purpose Backup Registers) block powered when the device > > + is shutdown. > > + Some AT91SAM9 SoCs provide a real RTC block, on those ones you'd > > + probably want to use the real RTC block instead of the RTT as an > > + RTT driver. > > You mean: > "instead of the RTT as an RTC" Boris, perhaps you should also update the Kconfig entries for RTC_DRV_AT91SAM9_RTT and RTC_DRV_AT91SAM9_GPBR to clarify that they are only used for legacy booting (and otherwise have no effect)? > With that, good description: thanks! > > Acked-by: Nicolas Ferre > > So, now we can think of what to do with the series: > > - Johan, do you want to "Ack" it? I had one comment to the slow-clock patch, but feel free to add my Acked-by: Johan Hovold to the whole series. Thanks, Johan