linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Chen <peter.chen@freescale.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: <balbi@ti.com>,
	Antoine Tenart <antoine.tenart@free-electrons.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<sebastian.hesselbarth@gmail.com>, <p.zabel@pengutronix.de>,
	<thomas.petazzoni@free-electrons.com>, <zmxu@marvell.com>,
	<devicetree@vger.kernel.org>, <linux-usb@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	<alexandre.belloni@free-electrons.com>, <jszhang@marvell.com>
Subject: Re: [PATCH v6 07/12] usb: chipidea: add a usb2 driver for ci13xxx
Date: Wed, 24 Sep 2014 19:29:05 +0800	[thread overview]
Message-ID: <20140924112902.GA23331@peterchendt> (raw)
In-Reply-To: <2923729.dtX0WmHSV0@wuerfel>

On Wed, Sep 24, 2014 at 10:30:41AM +0200, Arnd Bergmann wrote:
> On Wednesday 24 September 2014 09:44:19 Arnd Bergmann wrote:
> > 
> > We can also gradually move in some of the other glue drivers into
> > the main driver if the differences are small enough.
> > 
> 
> FWIW, I've just looked at the other glue drivers that already
> exist:
> 
> - zevio can just get merged into the common driver, all that seems
>   to be needed for that is the additional compatible string, and
>   keying off the ci_default_zevio_platdata on the .data field of
>   the of_device_id table.
> 
> - msm has a custom notifier, which justifies leaving it in a separate
>   driver, but it's also small enough that it wouldn't hurt to have
>   that merged into the main driver too.
> 
> - imx requires a lot of other things, in particular the dependency
>   on the usbmisc driver means we don't want to have that in the
>   core anyway, so we can't really merge that in.
> 
> - the proposed ar933x driver again looks almost trivial, so no reason
>   for a separate glue driver for that.
> 
> 	Arnd

Thanks, Arnd.

So, it is IP CORE LIB (you suggest) vs IP CORE Platform Driver
(dwc3, musb, chipidea) you are talking about, right? Except for
creating another platform driver as well as related DT node (optional),
are there any advantages compared to current IP core driver structure?

In this thread, we are talking about creating common platform driver for glue
layer, its design purpose (adapt it for as many as platforms) should be the
same, no matter the IP core part is a LIB or platform driver, am I missing
something?

-- 
Best Regards,
Peter Chen

  reply	other threads:[~2014-09-24 11:29 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-23 10:27 [PATCH v6 00/12] ARM: berlin: USB support Antoine Tenart
2014-09-23 10:27 ` [PATCH v6 01/12] reset: add the Berlin reset controller driver Antoine Tenart
2014-09-23 10:27 ` [PATCH v6 02/12] Documentation: bindings: add reset bindings docs for Marvell Berlin SoCs Antoine Tenart
2014-09-23 10:27 ` [PATCH v6 03/12] ARM: Berlin: select the reset controller Antoine Tenart
2014-09-23 10:28 ` [PATCH v6 04/12] ARM: dts: berlin: add a required reset property in the chip controller node Antoine Tenart
2014-09-23 10:28 ` [PATCH v6 05/12] phy: add the Berlin USB PHY driver Antoine Tenart
2014-09-23 10:28 ` [PATCH v6 06/12] Documentation: bindings: add doc for the Berlin USB PHY Antoine Tenart
2014-09-23 10:28 ` [PATCH v6 07/12] usb: chipidea: add a usb2 driver for ci13xxx Antoine Tenart
2014-09-23 10:39   ` Arnd Bergmann
2014-09-23 13:36     ` Antoine Tenart
2014-09-23 16:44       ` Arnd Bergmann
2014-09-23 16:55         ` Felipe Balbi
2014-09-23 17:37           ` Arnd Bergmann
2014-09-23 17:43             ` Felipe Balbi
2014-09-24  2:27             ` Peter Chen
2014-09-24  7:44               ` Arnd Bergmann
2014-09-24  8:30                 ` Arnd Bergmann
2014-09-24 11:29                   ` Peter Chen [this message]
2014-09-24 12:23                     ` Arnd Bergmann
2014-09-25  0:56                       ` Peter Chen
2014-09-25 14:15                       ` Felipe Balbi
2014-09-25 23:39                         ` Peter Chen
2014-09-26  0:37                           ` Felipe Balbi
2014-09-26  0:39                             ` Felipe Balbi
2014-09-26  7:20                               ` Arnd Bergmann
2014-09-26 15:43                                 ` Felipe Balbi
2014-09-28  0:40                             ` Peter Chen
2014-10-13  8:47                             ` Peter Chen
2014-09-25 14:09                 ` Felipe Balbi
2014-09-24 23:58   ` Sören Brinkmann
2014-09-29 14:57     ` Antoine Tenart
2014-09-25  1:16   ` Peter Chen
2014-09-25  7:11     ` Arnd Bergmann
2014-09-26  0:23       ` Peter Chen
2014-09-26  7:01         ` Arnd Bergmann
2014-09-25 19:12   ` Arnd Bergmann
2014-09-25 19:54     ` Antoine Tenart
2014-09-29 15:08   ` Antoine Tenart
2014-10-01 12:39     ` Antoine Tenart
2014-09-30  0:12   ` Peter Chen
2014-09-30 10:03     ` Arnd Bergmann
2014-09-30 12:39       ` Peter Chen
2014-09-30 13:43         ` Arnd Bergmann
2014-10-01  6:35           ` Peter Chen
2014-10-01  8:41             ` Arnd Bergmann
2014-10-01 12:25               ` Peter Chen
2014-10-01 23:40     ` Peter Chen
2014-09-23 10:28 ` [PATCH v6 08/12] Documentation: bindings: add doc for the USB2 ChipIdea USB driver Antoine Tenart
2014-09-23 10:28 ` [PATCH v6 09/12] ARM: dts: berlin: add BG2Q nodes for USB support Antoine Tenart
2014-09-23 10:28 ` [PATCH v6 10/12] ARM: dts: Berlin: enable USB on the BG2Q DMP Antoine Tenart
2014-09-23 10:28 ` [PATCH v6 11/12] ARM: dts: berlin: add BG2CD nodes for USB support Antoine Tenart
2014-09-23 10:28 ` [PATCH v6 12/12] ARM: dts: berlin: enable USB on the Google Chromecast Antoine Tenart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140924112902.GA23331@peterchendt \
    --to=peter.chen@freescale.com \
    --cc=alexandre.belloni@free-electrons.com \
    --cc=antoine.tenart@free-electrons.com \
    --cc=arnd@arndb.de \
    --cc=balbi@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jszhang@marvell.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=sebastian.hesselbarth@gmail.com \
    --cc=thomas.petazzoni@free-electrons.com \
    --cc=zmxu@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).