From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752403AbaJFJHc (ORCPT ); Mon, 6 Oct 2014 05:07:32 -0400 Received: from mail-wi0-f175.google.com ([209.85.212.175]:62712 "EHLO mail-wi0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752239AbaJFJHa (ORCPT ); Mon, 6 Oct 2014 05:07:30 -0400 Date: Mon, 6 Oct 2014 11:07:26 +0200 From: Robert Richter To: Arnaldo Carvalho de Melo Cc: Jean Pihet , Borislav Petkov , "linux-kernel@vger.kernel.org" , Fu Wei , Jiri Olsa , David Ahern , Ingo Molnar Subject: Re: perf & rasd integration plan Message-ID: <20141006090726.GQ20170@rric.localhost> References: <20140930132416.GB2799@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140930132416.GB2799@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30.09.14 10:24:16, Arnaldo Carvalho de Melo wrote: > Em Tue, Sep 30, 2014 at 11:06:21AM +0200, Jean Pihet escreveu: > > The plan is to move the small and generic functions first: util, > > xyarray, cpumap, thread_map etc; then evlist, evsel, trace-event, > > trace-event-parse; and finally integrate rasd into the tools/ dir. > > > > Any thought? Can evlist, evsel etc. be moved at once? > > > > Patches should come soon, when time allows. > > Why don't you add it to tools/rasd/ and in tools/rasd/Makefile you just > go on and add tools/perf/util/evlist.o et all to be linked directly, as > a first step. > > Then, as a second step, we can create a tools/lib/perf/evlist.c having > what is currently used by both tools/perf/ and tools/rasd/, i.e. what is > proven to be useful for something other than perf. It would be good to have tools/lib/perf or so with some base implementation to setup and connect to perf buffers. This is useful for tools not only in tools/. The rasd would be a good reference for this regardless if it is in tools/ or not. I am not sure whether and when rasd will be moved there. > As the need arises, we go on moving things into tools/lib/perf/evlist.c > et all from wherever it appeared first, be it from tools/rasd/, > tools/perf/util/evlist.c or anywhere else. > > Initial rule being that once it is used by multiple tools living in > tools/, then it deserves a place in tools/lib/perf/. So this wouldn't quite work well as it excludes tools not in tools/. -Robert > > Ditto for other stuff currently living in tools/perf/util/.