From: Lee Jones <lee.jones@linaro.org>
To: Johannes Pointner <johannes.pointner@gmail.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] dt: bindings: tps65217: add compatible property for subnodes
Date: Mon, 6 Oct 2014 22:22:32 +0100 [thread overview]
Message-ID: <20141006212232.GF18035@lee--X1> (raw)
In-Reply-To: <1660410.j399mvljTo@lenovobook>
On Thu, 25 Sep 2014, Johannes Pointner wrote:
> Add documentation for compatible property of subnodes.
>
> Signed-off-by: Johannes Pointner <johannes.pointner@br-automation.com>
> ---
> Documentation/devicetree/bindings/regulator/tps65217.txt | 7 ++++++-
> .../devicetree/bindings/video/backlight/tps65217-backlight.txt | 9 ++++++---
> 2 files changed, 12 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/regulator/tps65217.txt b/Documentation/devicetree/bindings/regulator/tps65217.txt
> index 4f05d20..8ae3a3b 100644
> --- a/Documentation/devicetree/bindings/regulator/tps65217.txt
> +++ b/Documentation/devicetree/bindings/regulator/tps65217.txt
> @@ -14,6 +14,9 @@ Required properties:
> Optional properties:
> - ti,pmic-shutdown-controller: Telling the PMIC to shutdown on PWR_EN toggle.
>
> +Required subnode properties:
> +- compatible: "ti,tps65217-pmic"
> +
> The valid names for regulators are:
> tps65217: dcdc1, dcdc2, dcdc3, ldo1, ldo2, ldo3 and ldo4
>
> @@ -23,9 +26,11 @@ Example:
>
> tps: tps@24 {
> compatible = "ti,tps65217";
> + reg = <0x24>;
> ti,pmic-shutdown-controller;
>
> - regulators {
> + tps_pmic: regulators {
How is the tps_pmic label used?
> + compatible = "ti,tps65217-pmic";
I'd like to see a '\n' here.
> dcdc1_reg: dcdc1 {
> regulator-min-microvolt = <900000>;
> regulator-max-microvolt = <1800000>;
> diff --git a/Documentation/devicetree/bindings/video/backlight/tps65217-backlight.txt b/Documentation/devicetree/bindings/video/backlight/tps65217-backlight.txt
> index 5fb9279..f92f154 100644
> --- a/Documentation/devicetree/bindings/video/backlight/tps65217-backlight.txt
> +++ b/Documentation/devicetree/bindings/video/backlight/tps65217-backlight.txt
> @@ -6,19 +6,22 @@ used to drive LEDs for use as backlights.
> Required properties:
> - compatible: "ti,tps65217"
> - reg: I2C slave address
> -- backlight: node for specifying WLED1 and WLED2 lines in TPS65217
> +- backlight: subnode for specifying WLED1 and WLED2 lines in TPS65217
> +
> +Required subnode properties:
> +- compatible: "ti,tps65217-bl"
> - isel: selection bit, valid values: 1 for ISEL1 (low-level) and 2 for ISEL2 (high-level)
> - fdim: PWM dimming frequency, valid values: 100, 200, 500, 1000
> - default-brightness: valid values: 0-100
>
> -Each regulator is defined using the standard binding for regulators.
>
> Example:
>
> tps: tps@24 {
> reg = <0x24>;
> compatible = "ti,tps65217";
I'd like to see a '\n' here.
> - backlight {
> + tps_bl: backlight {
Same here. Is this label used?
> + compatible = "ti,tps65217-bl";
> isel = <1>; /* 1 - ISET1, 2 ISET2 */
> fdim = <100>; /* TPS65217_BL_FDIM_100HZ */
> default-brightness = <50>;
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-10-06 21:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-25 6:31 [PATCH v2 2/2] dt: bindings: tps65217: add compatible property for subnodes Johannes Pointner
2014-10-06 21:22 ` Lee Jones [this message]
2014-10-08 9:14 ` Johannes Pointner
2014-10-08 10:47 ` Lee Jones
2014-10-08 10:59 ` Johannes Pointner
2014-10-08 13:30 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141006212232.GF18035@lee--X1 \
--to=lee.jones@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=johannes.pointner@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).