From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754273AbaJGPjJ (ORCPT ); Tue, 7 Oct 2014 11:39:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:64821 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753269AbaJGPjH (ORCPT ); Tue, 7 Oct 2014 11:39:07 -0400 Date: Tue, 7 Oct 2014 18:42:33 +0300 From: "Michael S. Tsirkin" To: David Miller Cc: linux-kernel@vger.kernel.org, rusty@rustcorp.com.au, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org Subject: Re: [PATCH 08/16] virtio_net: drop config_enable Message-ID: <20141007154233.GA9635@redhat.com> References: <1412525038-15871-9-git-send-email-mst@redhat.com> <20141006.150238.2180269239953265506.davem@davemloft.net> <20141007064915.GA2424@redhat.com> <20141007.113643.1462528588440998168.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141007.113643.1462528588440998168.davem@davemloft.net> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 07, 2014 at 11:36:43AM -0400, David Miller wrote: > From: "Michael S. Tsirkin" > Date: Tue, 7 Oct 2014 09:49:15 +0300 > > > On Mon, Oct 06, 2014 at 03:02:38PM -0400, David Miller wrote: > >> From: "Michael S. Tsirkin" > >> Date: Sun, 5 Oct 2014 19:07:13 +0300 > >> > >> > Now that virtio core ensures config changes don't arrive during probing, > >> > drop config_enable flag in virtio net. > >> > On removal, flush is now sufficient to guarantee that no change work is > >> > queued. > >> > > >> > This help simplify the driver, and will allow setting DRIVER_OK earlier > >> > without losing config change notifications. > >> > > >> > Signed-off-by: Michael S. Tsirkin > >> > >> It's hard for people on the networking side to review these changes > >> since you haven't CC:'d them on any of the postings necessary to > >> understand the context of the net/ and drivers/net/ changes. > >> > >> Please at a minimum CC: everyone on your header [PATCH 0/N] posting > >> so we know at least at a high level what is going on, and why. > >> > >> Thanks. > > > > It's a bit tricky for large patchsets - if I add everyone to 0/N > > then vger isn't happy with Cc list that is too large. > > > > What is your advice here? Cc just mailing lists on 0/N? > > > > FWIW this patchset is inteded for the virtio tree. > > CC: mailing lists and "focus" developers, a small carefully selected > group of people who would be strongly interested in this change. > > I really don't understand why this is so complicated, I've never run > into a situation where I had to CC: 200 people in my two decades of > kernel development :-/ Will do for the next version, thanks!