From: Frederic Weisbecker <fweisbec@gmail.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: Fix compile error seen in non-SMP builds
Date: Sat, 11 Oct 2014 15:16:21 +0200 [thread overview]
Message-ID: <20141011131618.GA4043@lerouge> (raw)
In-Reply-To: <1412990134-31186-1-git-send-email-linux@roeck-us.net>
On Fri, Oct 10, 2014 at 06:15:34PM -0700, Guenter Roeck wrote:
> Fix:
>
> In file included from ./arch/arm64/include/asm/irq_work.h:4:0,
> from include/linux/irq_work.h:46,
> from include/linux/perf_event.h:49,
> from include/linux/ftrace_event.h:9,
> from include/trace/syscall.h:6,
> from include/linux/syscalls.h:81,
> from init/main.c:18:
> ./arch/arm64/include/asm/smp.h:24:3:
> error: #error "<asm/smp.h> included in non-SMP build"
> # error "<asm/smp.h> included in non-SMP build"
> ^
> ./arch/arm64/include/asm/smp.h:27:0: warning: "raw_smp_processor_id" redefined
> #define raw_smp_processor_id() (current_thread_info()->cpu)
> ^
>
> and:
>
> In file included from ./arch/arm64/include/asm/irq_work.h:4:0,
> from include/linux/irq_work.h:46,
> from kernel/irq_work.c:11:
> ./arch/arm64/include/asm/smp_plat.h:56:30:
> error: ‘NR_CPUS’ undeclared here (not in a function)
> extern u64 __cpu_logical_map[NR_CPUS];
>
> by providing a helper function in smp_plat.h, similar to the arm implementation,
> and by removing NR_CPUS from smp_plat.h.
>
> Fixes: 3631073659d0 ("arm64: Tell irq work about self IPI support")
> Cc: Frederic Weisbecker <fweisbec@gmail.com>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
That looks good to me.
Note, ARM64 is one of the archs I couldn't test due to the lack of a
nolibc cross compiler in https://www.kernel.org/pub/tools/crosstool/
Thanks!
next prev parent reply other threads:[~2014-10-11 13:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-11 1:15 [PATCH] arm64: Fix compile error seen in non-SMP builds Guenter Roeck
2014-10-11 13:16 ` Frederic Weisbecker [this message]
2014-10-11 14:49 ` Guenter Roeck
2014-10-11 16:45 ` Alexei Starovoitov
2014-10-19 15:22 ` Guenter Roeck
2014-10-20 17:22 ` Catalin Marinas
2014-10-20 18:13 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141011131618.GA4043@lerouge \
--to=fweisbec@gmail.com \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).