From: Mark Rutland <mark.rutland@arm.com>
To: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"broonie@kernel.org" <broonie@kernel.org>,
"jason@lakedaemon.net" <jason@lakedaemon.net>,
"grant.likely@linaro.org" <grant.likely@linaro.org>
Subject: Re: [PATCH v2 1/1] Documentation: dt-bindings: Explain order in patch series
Date: Tue, 14 Oct 2014 10:25:52 +0100 [thread overview]
Message-ID: <20141014092552.GG16598@leverpostej> (raw)
In-Reply-To: <1412879047-24138-1-git-send-email-javier.martinez@collabora.co.uk>
On Thu, Oct 09, 2014 at 07:24:07PM +0100, Javier Martinez Canillas wrote:
> When posting a patch series that includes both code implementing a
> Device Tree binding and its associated documentation, the DT docs
> should come in the series before the implementation.
>
> This not only avoids checkpatch.pl to complain about undocumented
> bindings but also makes the review process easier.
>
> Document this convention since it may not be obvious.
>
> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Following the discussion around [1], this makes sense to me, so:
Acked-by: Mark Rutland <mark.rutland@arm.com>
Mark.
[1] http://lkml.kernel.org/r/54356666.4090003@collabora.co.uk
> ---
>
> Changes since v1:
> - Small typo error, sorry for the noise.
>
> Documentation/devicetree/bindings/submitting-patches.txt | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/submitting-patches.txt b/Documentation/devicetree/bindings/submitting-patches.txt
> index 042a027..b7ba01a 100644
> --- a/Documentation/devicetree/bindings/submitting-patches.txt
> +++ b/Documentation/devicetree/bindings/submitting-patches.txt
> @@ -12,6 +12,9 @@ I. For patch submitters
>
> devicetree@vger.kernel.org
>
> + 3) The Documentation/ portion of the patch should come in the series before
> + the code implementing the binding.
> +
> II. For kernel maintainers
>
> 1) If you aren't comfortable reviewing a given binding, reply to it and ask
> --
> 2.1.0
>
>
next prev parent reply other threads:[~2014-10-14 9:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-09 18:24 [PATCH v2 1/1] Documentation: dt-bindings: Explain order in patch series Javier Martinez Canillas
2014-10-14 9:25 ` Mark Rutland [this message]
2014-10-20 15:49 ` Jonathan Corbet
2014-10-20 19:42 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141014092552.GG16598@leverpostej \
--to=mark.rutland@arm.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=jason@lakedaemon.net \
--cc=javier.martinez@collabora.co.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).