From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752905AbaJPUUS (ORCPT <rfc822;w@1wt.eu>);
	Thu, 16 Oct 2014 16:20:18 -0400
Received: from mx1.redhat.com ([209.132.183.28]:20893 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751875AbaJPUUP (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 16 Oct 2014 16:20:15 -0400
Date: Thu, 16 Oct 2014 16:20:01 -0400 (EDT)
Message-Id: <20141016.162001.599580415052560455.davem@redhat.com>
To: mroos@linux.ee
Cc: iamjoonsoo.kim@lge.com, linux-kernel@vger.kernel.org, cl@linux.com,
        penberg@kernel.org, rientjes@google.com, akpm@linux-foundation.org,
        linux-mm@kvack.org, sparclinux@vger.kernel.org
Subject: Re: unaligned accesses in SLAB etc.
From: David Miller <davem@redhat.com>
In-Reply-To: <alpine.LRH.2.11.1410162313440.19924@adalberg.ut.ee>
References: <alpine.LRH.2.11.1410160956090.13273@adalberg.ut.ee>
	<20141016.160742.1639247937393238792.davem@redhat.com>
	<alpine.LRH.2.11.1410162313440.19924@adalberg.ut.ee>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Meelis Roos <mroos@linux.ee>
Date: Thu, 16 Oct 2014 23:16:44 +0300 (EEST)

>> > scripts/Makefile.build:352: recipe for target 'sound/modules.order' failed
>> > make[1]: *** [sound/modules.order] Bus error
>> > make[1]: *** Deleting file 'sound/modules.order'
>> > Makefile:929: recipe for target 'sound' failed
>> 
>> I just reproduced this on my Sun Blade 2500, so it can trigger on UltraSPARC-IIIi
>> systems too.
> 
> My bisection led to the folloowing commit but it seems irrelevant (I 
> have no sun4v on these machines):
> 
> 4ccb9272892c33ef1c19a783cfa87103b30c2784 is the first bad commit
> commit 4ccb9272892c33ef1c19a783cfa87103b30c2784
> Author: bob picco <bpicco@meloft.net>
> Date:   Tue Sep 16 09:26:47 2014 -0400
> 
>     sparc64: sun4v TLB error power off events
> 
> 
> However, the following chunk sound slightly suspicious:
> 
> +       if (fault_code & FAULT_CODE_BAD_RA)
> +               goto do_sigbus;
> +
> 
> because SIGNUS is what I got. For some machines, it killed chekroot 
> during startup, for some shells under some circumstances, for some sshd.

Good catch!

So I'm going to audit all the code paths to make sure we don't put garbage
into the fault_code value.