From: Oleg Nesterov <oleg@redhat.com>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: Michal Hocko <mhocko@suse.cz>,
David Rientjes <rientjes@google.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Tejun Heo <tj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: + freezer-check-oom-kill-while-being-frozen.patch added to -mm tree
Date: Fri, 17 Oct 2014 17:24:29 +0200 [thread overview]
Message-ID: <20141017152429.GA7227@redhat.com> (raw)
In-Reply-To: <CAM_iQpVZtOCzWA3wWuG5y7AyOBUx41-81jrt+dSeHvr6eHY4RA@mail.gmail.com>
On 10/16, Cong Wang wrote:
>
> On Thu, Oct 16, 2014 at 3:22 PM, Oleg Nesterov <oleg@redhat.com> wrote:
> > On 10/16, Cong Wang wrote:
> >>
> >> it will always stay in asleep after schedule()?
> >
> > Not always. But it will stay asleep in this particular case.
>
> Hmm, so we still need to wake it up in oom killer:
>
> if (test_tsk_thread_flag(task, TIF_MEMDIE)) {
> if (unlikely(frozen(task)))
> wake_up_state(task, TASK_UNINTERRUPTIBLE);
>
> I will update the patch if Michal doesn't.
I think it would be better to simply keep that __thaw_task() in
oom_scan_process_thread().
Oleg.
next prev parent reply other threads:[~2014-10-17 15:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-16 20:39 + freezer-check-oom-kill-while-being-frozen.patch added to -mm tree Oleg Nesterov
2014-10-16 20:53 ` Cong Wang
2014-10-16 21:11 ` Oleg Nesterov
2014-10-16 21:19 ` Cong Wang
2014-10-16 21:35 ` Oleg Nesterov
2014-10-16 21:52 ` Cong Wang
2014-10-16 22:22 ` Oleg Nesterov
2014-10-17 2:33 ` Cong Wang
2014-10-17 7:46 ` [PATCH -v2] freezer: check OOM kill while being frozen Michal Hocko
2014-10-17 16:10 ` Oleg Nesterov
2014-10-17 16:20 ` Michal Hocko
2014-10-20 15:17 ` Michal Hocko
2014-10-20 17:40 ` Oleg Nesterov
2014-10-17 15:24 ` Oleg Nesterov [this message]
2014-10-17 16:07 ` + freezer-check-oom-kill-while-being-frozen.patch added to -mm tree Michal Hocko
2014-10-17 6:59 ` Michal Hocko
2014-10-17 15:31 ` Oleg Nesterov
2014-10-17 16:06 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141017152429.GA7227@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@suse.cz \
--cc=rientjes@google.com \
--cc=rjw@rjwysocki.net \
--cc=tj@kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).