From: Christoph Hellwig <hch@infradead.org>
To: Dmitry Monakhov <dmonakhov@openvz.org>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
viro@zeniv.linux.org.uk, hch@infradead.org
Subject: Re: [PATCH 2/4] fs: add fadvise file_operation
Date: Sun, 19 Oct 2014 07:51:38 -0700 [thread overview]
Message-ID: <20141019145138.GB9593@infradead.org> (raw)
In-Reply-To: <1413645688-13524-3-git-send-email-dmonakhov@openvz.org>
On Sat, Oct 18, 2014 at 07:21:26PM +0400, Dmitry Monakhov wrote:
> sys_fadvise result in direct f_mode modification, which may be not
> suitable for some unusual filesytems where file mode invariant is more
> complex. In order to support such filesystems we have to delegate fadvise
> logic to filesystem layer.
Is there a real use case for it? So for it seems mostly about ecryptfs,
and even that use is lacking a proper explanation.
Also fadvice and set_flags seem entirely unrelated, I don't understand
why you're throwing fadvice in thise series.
next prev parent reply other threads:[~2014-10-19 14:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-18 15:21 [PATCH 0/4] fs: fcntl/fadvice fixes v2 Dmitry Monakhov
2014-10-18 15:21 ` [PATCH 1/4] fs: fcntl add set_flags wrapper -v2 Dmitry Monakhov
2014-10-18 15:21 ` [PATCH 2/4] fs: add fadvise file_operation Dmitry Monakhov
2014-10-19 14:51 ` Christoph Hellwig [this message]
2014-10-21 8:31 ` Dmitry Monakhov
2014-10-18 15:21 ` [PATCH 3/4] ecryptfs: add fadvise/set_flags calbacks Dmitry Monakhov
2014-10-19 14:50 ` Christoph Hellwig
2014-10-18 15:21 ` [PATCH 4/4] cifs: add set_flag callback Dmitry Monakhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141019145138.GB9593@infradead.org \
--to=hch@infradead.org \
--cc=dmonakhov@openvz.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).